From: Jie Liu <lj8175@gmail.com>
To: Tom Tromey <tromey@redhat.com>,
java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org,
Joel Sherrill <joel.sherrill@oarcorp.com>
Subject: Re: [PATCH] [JAVA] Double.parseDouble(null) throw NullPointerException
Date: Tue, 09 Aug 2011 17:29:00 -0000 [thread overview]
Message-ID: <CABc96T_dL8gN9LwtE+Gb_WuzAv1XvCaU+rbZkxhNb-Wb=EdBJw@mail.gmail.com> (raw)
In-Reply-To: <m3zkjkugz9.fsf@fleche.redhat.com>
Hi Tom,
RTEMS does not have virtual memory management, so there is no error
when access the 0 address on rtems.
So 'str->length()' donot throw NPE and just return an meaningless value.
Ps: There is a test:
http://code.google.com/p/rtemsgcj/source/browse/trunk/algorithm/20110810NPE/?r=127,
npe.c is the main file and *.scn is the output.
Thanks,
Jie
2011/8/8 Tom Tromey <tromey@redhat.com>:
>>>>>> "Jie" == Jie Liu <lj8175@gmail.com> writes:
>
> Jie> + if(str == NULL)
> Jie> + throw new NullPointerException();
> Jie> +
> Jie> int length = str->length();
>
> Why doesn't 'str->length()' throw the NPE?
>
> Tom
>
=========== The first mail, for adding Joel ===========
Hi,
When I use gcj on an RTOS(RTEMS), Double.parseDouble(null) throw
NumberFormatException, but it should throw NullPointerException. So I
add the patch below:
Index: natVMDouble.cc
===================================================================
--- natVMDouble.cc (revision 172224)
+++ natVMDouble.cc (working copy)
@@ -19,6 +19,7 @@
#include <java/lang/VMDouble.h>
#include <java/lang/Character.h>
#include <java/lang/NumberFormatException.h>
+#include <java/lang/NullPointerException.h>
#include <jvm.h>
#include <stdio.h>
@@ -162,6 +163,9 @@
jdouble
java::lang::VMDouble::parseDouble(jstring str)
{
+ if(str == NULL)
+ throw new NullPointerException();
+
int length = str->length();
while (length > 0
The testsuite/Throw_2.java has been PASS after this patch. what do you
think about this patch?
Thanks,
Jie
next prev parent reply other threads:[~2011-08-09 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABc96T_0THd_tKzdHSjD-xcPd7=dqoFkr0aRwrdvx-h4s2Hnxg@mail.gmail.com>
2011-08-07 11:00 ` Jie Liu
2011-08-08 14:16 ` Tom Tromey
2011-08-09 17:29 ` Jie Liu [this message]
2011-08-10 13:34 ` Tom Tromey
2011-08-10 15:59 ` Jie Liu
2011-08-10 16:41 ` Tom Tromey
2011-08-12 7:39 ` Jie Liu
2011-08-12 16:22 ` Bryce McKinlay
2011-08-12 17:12 ` Jie Liu
2011-08-14 13:04 ` Tom Tromey
2011-08-15 14:07 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABc96T_dL8gN9LwtE+Gb_WuzAv1XvCaU+rbZkxhNb-Wb=EdBJw@mail.gmail.com' \
--to=lj8175@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=joel.sherrill@oarcorp.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).