public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jie Liu <lj8175@gmail.com>
Cc: java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org,
	       Joel Sherrill <joel.sherrill@oarcorp.com>
Subject: Re: [PATCH] [JAVA] Double.parseDouble(null) throw NullPointerException
Date: Wed, 10 Aug 2011 13:34:00 -0000	[thread overview]
Message-ID: <m339hatrqv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CABc96T_dL8gN9LwtE+Gb_WuzAv1XvCaU+rbZkxhNb-Wb=EdBJw@mail.gmail.com>	(Jie Liu's message of "Wed, 10 Aug 2011 00:41:22 +0800")

>>>>> "Jie" == Jie Liu <lj8175@gmail.com> writes:

Jie> RTEMS does not have virtual memory management, so there is no error
Jie> when access the 0 address on rtems.
Jie> So 'str->length()' donot throw NPE and just return an meaningless value.

If you compile the Java parts of the library with -fcheck-references, it
should work.  This is something you have to set up as part of the port,
as it is decided at (libgcj-) configure time.

This won't help with the native code.  IIRC in the end we just gave up
on that; if you wanted real correctness you would have to add a null
check at every dereference in the C++ code.  I believe Andrew had a g++
patch to do this in the compiler, but it was rejected.

Tom

  reply	other threads:[~2011-08-09 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABc96T_0THd_tKzdHSjD-xcPd7=dqoFkr0aRwrdvx-h4s2Hnxg@mail.gmail.com>
2011-08-07 11:00 ` Jie Liu
2011-08-08 14:16   ` Tom Tromey
2011-08-09 17:29     ` Jie Liu
2011-08-10 13:34       ` Tom Tromey [this message]
2011-08-10 15:59         ` Jie Liu
2011-08-10 16:41           ` Tom Tromey
2011-08-12  7:39             ` Jie Liu
2011-08-12 16:22               ` Bryce McKinlay
2011-08-12 17:12             ` Jie Liu
2011-08-14 13:04               ` Tom Tromey
2011-08-15 14:07   ` Andrew Haley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339hatrqv.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=joel.sherrill@oarcorp.com \
    --cc=lj8175@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).