From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: java-patches@gcc.gnu.org, libffi-discuss@sourceware.org,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32
Date: Wed, 18 Jul 2012 19:13:00 -0000 [thread overview]
Message-ID: <CAFULd4Za9_R6znB3khoqKh42L+npbwcUzRJ58g7mFef3OY-ZSw@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOoOJVHV7XjpBSNDPi-T9_oiFCKkxc2uXADKGoR=N0=MCA@mail.gmail.com>
On Wed, Jul 18, 2012 at 9:10 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32.
>>>> It fixed:
>>>>
>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982
>>>
>>> Here is the patch with updated ChangeLog entry. X32 has the same issue
>>> as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW:
>>>
>>> http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html
>>> http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html
>>>
>>> The same fix is needed for x32. OK for trunk?
>>>
>>> 2012-07-16 H.J. Lu <hongjiu.lu@intel.com>
>>>
>>> * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for
>>> x32.
>>> (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32.
>>
>> How did you tested this patch? Does it fix all the problems from
>> PR53982, including the one that is not 100% reproducible?
>>
>
> I tested it on Linux/x32. All libjava tests are passing now for x32 with
> this patch.
OK then.
Thanks,
Uros.
prev parent reply other threads:[~2012-07-18 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120716201408.GA5091@intel.com>
2012-07-18 16:27 ` H.J. Lu
2012-07-18 18:44 ` Uros Bizjak
2012-07-18 19:11 ` H.J. Lu
2012-07-18 19:13 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4Za9_R6znB3khoqKh42L+npbwcUzRJ58g7mFef3OY-ZSw@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=java-patches@gcc.gnu.org \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).