From: Andïï <gnu_andrew@member.fsf.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Java Patch List <java-patches@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR58669: does not detect all cpu cores/threads
Date: Fri, 18 Oct 2013 15:42:00 -0000 [thread overview]
Message-ID: <CAFXTvn7nSaJzAPWhE2XbmL1+t3c_8BVWPc=vnF87in=etxJVmg@mail.gmail.com> (raw)
In-Reply-To: <87a9i7s48n.fsf@fleche.redhat.com>
On 18 October 2013 03:27, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Andrew" == Andrew <gnu_andrew@member.fsf.org> writes:
>
> Andrew> +#ifdef HAVE_UNISTD_H
> Andrew> + procs = sysconf(_SC_NPROCESSORS_ONLN);
> Andrew> +#endif
>
> Space before the "(".
>
> Technically you should probably check for sysconf in configure.ac.
> I'm not sure whether it matters any more.
>
> I think _SC_NPROCESSORS_ONLN is not portable though.
>
> Tom
I can add an #ifdef _SC_NPROCESSORS_ONLN around it too.
Is that enough to imply we have sysconf too?
--
Andii :-)
prev parent reply other threads:[~2013-10-18 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 1:16 Andrew
2013-10-18 2:27 ` Tom Tromey
2013-10-18 15:42 ` Andïï [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFXTvn7nSaJzAPWhE2XbmL1+t3c_8BVWPc=vnF87in=etxJVmg@mail.gmail.com' \
--to=gnu_andrew@member.fsf.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).