From: Richard Guenther <richard.guenther@gmail.com>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org,
Eric Botcazou <ebotcazou@adacore.com>
Subject: Re: [patch][rfa] Do not call output_constant from the front end
Date: Wed, 28 Mar 2012 10:02:00 -0000 [thread overview]
Message-ID: <CAFiYyc0NN9CpgEe8qrT3vt--qvXwd0ahJw=aeC7zZpXPpv-P_A@mail.gmail.com> (raw)
In-Reply-To: <CABu31nN--GqGPuaGjqq6ZQBdNYwp0wkWO06A5NJ+fk1igig06g@mail.gmail.com>
On Wed, Mar 28, 2012 at 12:23 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Tue, Mar 27, 2012 at 11:51 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>> On Tue, Mar 27, 2012 at 11:07 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>>>> With this patch a variable named "_Jv_CLS" is written out. The
>>>> assembly before and after the patch is the same, except for the
>>>> variable name. I want to write out a nameless variable but I don't
>>>> know how.
>>>
>>> Try tree_output_constant_def.
>>
>> I didn't know about this function. But as far as I can tell, there is
>> no way to instruct that function to put the data in a specific
>> section. In the Java case, the data must be put in the .jcr section. I
>> suppose that can be achieved with a bit more re-working of varasm, but
>> not with the code as-is. Thanks for the pointer, though!
>
> It also doesn't appear to be possible to adjust the alignment via
> tree_output_constant_def(), so going down that path seems more trouble
> than it's worth.
>
> Therefore, an RFA for the attached patch. Bootstrapped&tested on
> powerpc64-unknown-linux-gnu. OK?
Ok.
Thanks for applying TLC to Java.
Richard.
> Ciao!
> Steven
next prev parent reply other threads:[~2012-03-28 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 20:36 [patch] " Steven Bosscher
2012-03-27 21:07 ` Eric Botcazou
2012-03-27 21:52 ` Steven Bosscher
2012-03-27 22:23 ` [patch][rfa] " Steven Bosscher
2012-03-28 7:46 ` Andrew Haley
2012-03-28 10:02 ` Richard Guenther [this message]
2012-03-29 21:04 ` Steven Bosscher
2012-04-02 12:24 ` Rainer Orth
2012-04-02 12:29 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0NN9CpgEe8qrT3vt--qvXwd0ahJw=aeC7zZpXPpv-P_A@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).