public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	GCJ-patches <java-patches@gcc.gnu.org>,
		"libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Subject: Re: [patch] [libffi] do not install libffi library, headers and documentation
Date: Tue, 19 Feb 2013 09:13:00 -0000	[thread overview]
Message-ID: <CAFiYyc0xEARf_whS5J=9w2wYBPYbiuJ7gdwsOD=_+PyRf+sz0Q@mail.gmail.com> (raw)
In-Reply-To: <51225EBE.1050509@ubuntu.com>

On Mon, Feb 18, 2013 at 6:02 PM, Matthias Klose <doko@ubuntu.com> wrote:
> Am 12.02.2013 13:45, schrieb Richard Biener:
>> On Tue, Feb 12, 2013 at 1:44 PM, Richard Biener
>> <richard.guenther@gmail.com> wrote:
>>> On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose <doko@ubuntu.com> wrote:
>>>> The libffi library, headers and documentation are still installed, although
>>>> libffi provides separate releases for a long time.  So do not install these
>>>> anymore as part of a GCC install.  Tested with a build and an install with go
>>>> and java enabled (both using libffi_convenience). Ok for the trunk?
>>>
>>> openSUSE is using the GCC provided libffi, so no, this is not ok (not at this
>>> stage anyway).  Also proper not-installing libffi would work by disabling
>>> the maybe-install-target-libffi at the toplevel, not changing libffi makfiles
>>> (which are supposed to be imported from upstream, no?)
>>
>> Thus, add no_install= true; to the libffi target module
>
> updated patch attached, checked with a make install that no ffi headers and
> libraries are installed. If not ok for 4.8, ok for 4.9 when it opens?

I'm fine with that variant but I'd like to see another ok.  No preference as to
whether to target 4.8 or 4.9.

Richard.

>   Matthias
>

  reply	other threads:[~2013-02-19  9:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 12:30 Matthias Klose
2013-02-12 12:44 ` Richard Biener
2013-02-12 12:46   ` Richard Biener
2013-02-18 17:03     ` Matthias Klose
2013-02-19  9:13       ` Richard Biener [this message]
2013-03-26 20:04         ` [ping] " Matthias Klose
2013-03-26 20:28           ` Ian Lance Taylor
2013-03-26 20:48             ` Anthony Green
2013-03-30 11:26               ` Matthias Klose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc0xEARf_whS5J=9w2wYBPYbiuJ7gdwsOD=_+PyRf+sz0Q@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=doko@ubuntu.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).