[Bug libgcj/15719] New: GIJ Interpeter: Problem with NaN / infinity comparisons

[Bug libgcj/15719] New: GIJ Interpeter: Problem with NaN / infinity comparisons

[mckinlay at redhat dot com]

The following test case produces the wrong result when compiled to bytecode and
run with the gij interpreter.

public class Test
{
  public static void main(String[] args)
  {
    System.out.println(blah(Double.NaN));    
  }
  
  static boolean blah(double a)
  {
    return (a < Double.POSITIVE_INFINITY);
  }
}

Expected output:
false

Actual output:
true

-- 
           Summary: GIJ Interpeter: Problem with NaN / infinity comparisons
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mckinlay at redhat dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-29 01:06 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-29 01:06:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-21 17:05 -------
I tried this but I couldn't reproduce.
I'm using current cvs trunk, but I built libgcj with -g
(so it could still be some optimization bug).

FWIW we implement dcmpg and the other floating point
comparison opcodes using C++ ">", "<", etc.
So if there is a bug here I suspect it will turn out
to be a g++ bug and not a bug in the interpreter.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-21 03:58 -------
Hmm, I also get true on the mainline on powerpc-darwin.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2004-05-29 01:06:33         |2004-12-21 03:58:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-12-21 20:03 -------
This now fails for me with cvs head gij.
It also fails for 3.3 and 3.4 gij.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-12-21 20:22 -------
I have a patch for this.
It is a dumb buglet in the dcmpl and dcmpg opcodes.
fcmpl and fcmpg are handled correctly.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-05 19:03 -------
Subject: Bug 15719

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-01-05 19:03:13

Modified files:
	libjava        : ChangeLog interpret.cc 

Log message:
	PR libgcj/15719:
	* interpret.cc (run) <insn_dcmpl, insn_dcmpg>: Set tmpval
	correctly.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3271&r2=1.3272
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/interpret.cc.diff?cvsroot=gcc&r1=1.47&r2=1.48



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719

[Bug libgcj/15719] GIJ Interpeter: Problem with NaN / infinity comparisons

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-05 19:08 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15719