[Bug java/16789] New: ICE in force_evaluation_order() on valid code

[Bug java/16789] New: ICE in force_evaluation_order() on valid code

[mckinlay at redhat dot com]

The following test case segfaults in force_evaluation_order() when compiling to
 native.

When compiling the same test to bytecode, the compiler does not crash, but the
generated bytecode is invalid (fails to verify on both gij and Sun's VM)

public class Crash
{
  public static void main(String[] args)
  {
    System.out.println(Thread.currentThread().holdsLock(this));
  }
}

-- 
           Summary: ICE in force_evaluation_order() on valid code
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mckinlay at redhat dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[mckinlay at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |3.5.0 3.3.4 3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-07-27 20:51 -------
Crash.java: In class `Crash':
Crash.java: In method `Crash.main(java.lang.String[])':
Crash.java:5: error: Keyword `this' used outside allowed context.
       System.out.println(Thread.currentThread().holdsLock(this));
                                                           ^
1 error

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-07-27 20:54 -------
This is the code which ICE:
public class Crash
{
  public void main(String[] args)
  {
    System.out.println(Thread.currentThread().holdsLock(this));
  }
}

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-07-27 20:54:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-07-27 20:55 -------
Andrew's version of the test case is correct. "static" should be removed.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-07-27 20:56 -------
public class Crash
{
  public void foo()
  {
    System.out.println(Thread.currentThread().holdsLock(this));
  }
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-07-27 20:57 -------
Lets look at the code:
3190            arg = TREE_OPERAND (node, 0);
3191
3192          arg = TREE_OPERAND (arg, 1);
3193
3194          /* Not having a list of argument here is an error. */
3195          if (TREE_CODE (arg) != TREE_LIST)
3196            abort ();

This is wrong when there is no arguments to the function which is true for currentThread.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-07-27 21:04 -------
I'm not so sure. The fact that invalid bytecode is generated (bytecode
compilation doesnt call force_evalution_order) leads me to suspect that
something wen't wrong earlier. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-21 20:02 -------
I'm testing a patch for this.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
      Known to fail|4.0 3.3.4 3.4.2             |4.0.0 3.3.4 3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-21 22:25 -------
*** Bug 15475 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |green at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-24 03:00 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02134.html>. Also this fixes the 
wrong-code with byte-code output.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-24 15:39 -------
Subject: Bug 16789

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2004-09-24 15:39:17

Modified files:
	gcc/java       : ChangeLog parse.y expr.c 

Log message:
	PR java/16789:
	* parse.y (resolve_qualified_expression_name): Set
	CAN_COMPLETE_NORMALLY on first call when chaining static calls.
	* expr.c (force_evaluation_order): Check for empty argument list
	after stripping COMPOUND_EXPR.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1461&r2=1.1462
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&r1=1.508&r2=1.509
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/expr.c.diff?cvsroot=gcc&r1=1.204&r2=1.205



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-24 15:41 -------
Subject: Bug 16789

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2004-09-24 15:41:17

Modified files:
	libjava        : ChangeLog 
Added files:
	libjava/testsuite/libjava.lang: pr16789.java pr16789.out 

Log message:
	PR java/16789:
	* testsuite/libjava.lang/pr16789.out: New file.
	* testsuite/libjava.lang/pr16789.java: New file.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3087&r2=1.3088
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/pr16789.java.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/pr16789.out.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-24 15:41 -------
Fix checked in.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789

[Bug java/16789] ICE in force_evaluation_order() on valid code

[tromey at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16789