public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgcj/17013] gij vtable layout bug
  2004-08-12 21:29 [Bug libgcj/17013] New: gij vtable layout bug tromey at gcc dot gnu dot org
@ 2004-08-12 21:29 ` tromey at gcc dot gnu dot org
  2004-08-12 22:10 ` [Bug libgcj/17013] gij vtable layout: hidden package-private method can be overridden mckinlay at redhat dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: tromey at gcc dot gnu dot org @ 2004-08-12 21:29 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From tromey at gcc dot gnu dot org  2004-08-12 21:29 -------
Created an attachment (id=6919)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6919&action=view)
test case files


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17013


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17013] New: gij vtable layout bug
@ 2004-08-12 21:29 tromey at gcc dot gnu dot org
  2004-08-12 21:29 ` [Bug libgcj/17013] " tromey at gcc dot gnu dot org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: tromey at gcc dot gnu dot org @ 2004-08-12 21:29 UTC (permalink / raw)
  To: java-prs

The attached test case should print "p2.der.m",
but with gij it prints "p1.dder.m".
That is wrong, since p1.dder.m does not override p2.der.m.
Run as "gij p2.der"

-- 
           Summary: gij vtable layout bug
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tromey at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17013


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17013] gij vtable layout: hidden package-private method can be overridden
  2004-08-12 21:29 [Bug libgcj/17013] New: gij vtable layout bug tromey at gcc dot gnu dot org
  2004-08-12 21:29 ` [Bug libgcj/17013] " tromey at gcc dot gnu dot org
@ 2004-08-12 22:10 ` mckinlay at redhat dot com
  2004-09-02  2:37 ` tromey at gcc dot gnu dot org
  2004-12-01 22:46 ` tromey at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: mckinlay at redhat dot com @ 2004-08-12 22:10 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From mckinlay at redhat dot com  2004-08-12 22:10 -------
_Jv_LayoutVTableMethods() needs to check that classes are in the same package
before allowing a pkg-private method to be overriden. vtable layout for BC-ABI
most likely has the same bug. There is a FIXME in the code for this:

      // FIXME: Must check that we don't override:
      // - Package-private method where superclass is in different package.
      // - Final or less-accessible declaration in superclass (check binary 
      //   spec, do we allocate new vtable entry or put throw node in vtable?)
      // - Static or private method in superclass.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-08-12 22:10:24
               date|                            |
            Summary|gij vtable layout bug       |gij vtable layout: hidden
                   |                            |package-private method can
                   |                            |be overridden


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17013


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17013] gij vtable layout: hidden package-private method can be overridden
  2004-08-12 21:29 [Bug libgcj/17013] New: gij vtable layout bug tromey at gcc dot gnu dot org
  2004-08-12 21:29 ` [Bug libgcj/17013] " tromey at gcc dot gnu dot org
  2004-08-12 22:10 ` [Bug libgcj/17013] gij vtable layout: hidden package-private method can be overridden mckinlay at redhat dot com
@ 2004-09-02  2:37 ` tromey at gcc dot gnu dot org
  2004-12-01 22:46 ` tromey at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: tromey at gcc dot gnu dot org @ 2004-09-02  2:37 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-02 02:37 -------
I checked in a fix for this on the BC branch today.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17013


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17013] gij vtable layout: hidden package-private method can be overridden
  2004-08-12 21:29 [Bug libgcj/17013] New: gij vtable layout bug tromey at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-09-02  2:37 ` tromey at gcc dot gnu dot org
@ 2004-12-01 22:46 ` tromey at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: tromey at gcc dot gnu dot org @ 2004-12-01 22:46 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From tromey at gcc dot gnu dot org  2004-12-01 22:46 -------
Fixed by the BC branch merge


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17013


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-12-01 22:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-12 21:29 [Bug libgcj/17013] New: gij vtable layout bug tromey at gcc dot gnu dot org
2004-08-12 21:29 ` [Bug libgcj/17013] " tromey at gcc dot gnu dot org
2004-08-12 22:10 ` [Bug libgcj/17013] gij vtable layout: hidden package-private method can be overridden mckinlay at redhat dot com
2004-09-02  2:37 ` tromey at gcc dot gnu dot org
2004-12-01 22:46 ` tromey at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).