public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgcj/17079] New: [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler
@ 2004-08-18 11:58 greenrd at greenrd dot org
  2004-08-18 14:52 ` [Bug libgcj/17079] " pinskia at gcc dot gnu dot org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: greenrd at greenrd dot org @ 2004-08-18 11:58 UTC (permalink / raw)
  To: java-prs

There is a typo in java/util/logging/Handler.java. To be consistent with the
javadoc comment, which requires log messages whose log level is AT the log
threshold to be accepted, apply this patch:

--- libjava/java/util/logging/Handler.java~     2004-08-18 12:57:00.000000000 +0100
+++ libjava/java/util/logging/Handler.java      2004-08-18 12:56:21.000000000 +0100
@@ -378,7 +378,7 @@
    */
   public boolean isLoggable(LogRecord record)
   {
-    if (record.getLevel().intValue() <= level.intValue())
+    if (record.getLevel().intValue() < level.intValue())
       return false;
      
     if (filter != null)

-- 
           Summary: [PATCH] Log messages whose logging level is equal to the
                    threshold discarded by java.util.logging.Handler
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: greenrd at greenrd dot org
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17079


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17079] [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler
  2004-08-18 11:58 [Bug libgcj/17079] New: [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler greenrd at greenrd dot org
@ 2004-08-18 14:52 ` pinskia at gcc dot gnu dot org
  2004-08-18 15:51 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-08-18 14:52 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-18 14:52 -------
Patches goto java-patches@gcc.gnu.org with a changelog after reading <http://gcc.gnu.org/
contribute.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-08-18 14:52:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17079


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17079] [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler
  2004-08-18 11:58 [Bug libgcj/17079] New: [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler greenrd at greenrd dot org
  2004-08-18 14:52 ` [Bug libgcj/17079] " pinskia at gcc dot gnu dot org
@ 2004-08-18 15:51 ` cvs-commit at gcc dot gnu dot org
  2004-08-18 15:55 ` mckinlay at redhat dot com
  2004-08-18 15:55 ` mckinlay at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-08-18 15:51 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-08-18 15:51 -------
Subject: Bug 17079

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bryce@gcc.gnu.org	2004-08-18 15:51:48

Modified files:
	libjava        : ChangeLog 
	libjava/java/util/logging: Handler.java 

Log message:
	2004-08-18  Bryce McKinlay  <mckinlay@redhat.com>
	
	PR libgcj/17079
	* java/util/logging/Handler.java (isLoggable): Accept record if its
	log level equals the threshold level. From Robin Green.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3008&r2=1.3009
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/util/logging/Handler.java.diff?cvsroot=gcc&r1=1.3&r2=1.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17079


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17079] [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler
  2004-08-18 11:58 [Bug libgcj/17079] New: [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler greenrd at greenrd dot org
                   ` (2 preceding siblings ...)
  2004-08-18 15:55 ` mckinlay at redhat dot com
@ 2004-08-18 15:55 ` mckinlay at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: mckinlay at redhat dot com @ 2004-08-18 15:55 UTC (permalink / raw)
  To: java-prs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17079


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libgcj/17079] [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler
  2004-08-18 11:58 [Bug libgcj/17079] New: [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler greenrd at greenrd dot org
  2004-08-18 14:52 ` [Bug libgcj/17079] " pinskia at gcc dot gnu dot org
  2004-08-18 15:51 ` cvs-commit at gcc dot gnu dot org
@ 2004-08-18 15:55 ` mckinlay at redhat dot com
  2004-08-18 15:55 ` mckinlay at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: mckinlay at redhat dot com @ 2004-08-18 15:55 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From mckinlay at redhat dot com  2004-08-18 15:55 -------
Fix checked in.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17079


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-08-18 15:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-18 11:58 [Bug libgcj/17079] New: [PATCH] Log messages whose logging level is equal to the threshold discarded by java.util.logging.Handler greenrd at greenrd dot org
2004-08-18 14:52 ` [Bug libgcj/17079] " pinskia at gcc dot gnu dot org
2004-08-18 15:51 ` cvs-commit at gcc dot gnu dot org
2004-08-18 15:55 ` mckinlay at redhat dot com
2004-08-18 15:55 ` mckinlay at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).