[Bug libgcj/17002] New: java.util.TimeZone.getDefault() is broken

[Bug libgcj/17002] New: java.util.TimeZone.getDefault() is broken

[mark at gcc dot gnu dot org]

TimeZone.getDefault() has two bugs mapping short timezone names (plus
GMT-offset) to long/display timezone information.

- The interface between getDefault() and the native getDefaultTimeZoneId() is
unclear. Which means that the result of getDefaultTimeZoneId() is not always
mapped to the correct TimeZone.

- getDefaultTimeZoneId() should always return the standard (std) short timezone
name, never the alternative (dst) Daylight Savings Time name. When it returns a
dst name the getDefault() mapping from short name to long/display timezone name
also breaks.

-- 
           Summary: java.util.TimeZone.getDefault() is broken
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: mark at klomp dot org
        ReportedBy: mark at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[mark at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |16990
              nThis|                            |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-08-12 13:39:51
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-08-26 16:11 -------
Subject: Bug 17002

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	mark@gcc.gnu.org	2004-08-26 16:10:54

Modified files:
	libjava        : ChangeLog 
	libjava/java/util: TimeZone.java natTimeZone.cc 

Log message:
	2004-08-26  Mark Wielaard  <mark@klomp.org>
	
	Fixes PR libgcj/17002:
	* java/util/TimeZone.java (defaultZone): Try a couple of ways to get
	a TimeZoneId string and then try to convert that to a TimeZone with
	getDefaultSystemTimeZone(String).
	(timezones0): Changed type from Hashtable to HashMap.
	(timezones): Create HashMap, not Hashtable.
	(getDefaultTimeZone): New method, rewritten from CNI version.
	(readTimeZoneFile): New method.
	(readtzFile): Likewise.
	(skipFully): Likewise.
	* java/util/natTimeZone.cc (getSystemTimeZone): Renamed to
	getDefaultTimeZoneId and rewritten.
	(getDefaultTimeZoneId): Rewritten in java.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3020&r2=1.3021
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/util/TimeZone.java.diff?cvsroot=gcc&r1=1.18&r2=1.19
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/util/natTimeZone.cc.diff?cvsroot=gcc&r1=1.6&r2=1.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-26 18:22 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-08-26 19:43 -------
Unfortunately, this isn't yet fixed for some platforms, such as Fedora Core 2. 

FC2 does not set the TZ environment variable, and it does not have an
/etc/timezone file. 

Here's the test case:

import java.util.TimeZone;

public class TZ2
{
  public static void main(String[] args)
  {
    TimeZone tz = TimeZone.getDefault();
    System.out.println (tz.getID());
  }
}

$ java TZ2
America/Toronto

$ gij TZ2
EST

I straced Sun's JVM to see if I could tell how it was getting the timezone ID:

open("/etc/sysconfig/clock", O_RDONLY)  = 4
fstat64(4, {st_mode=S_IFREG|0644, st_size=42, ...}) = 0
mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
0xea75d000
read(4, "ZONE=\"America/Toronto\"\nUTC=true\n"..., 4096) = 42
close(4)                                = 0

Looks like we need to try the /etc/sysconfig/clock file also?


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[mark at klomp dot org]

------- Additional Comments From mark at klomp dot org  2004-08-26 20:34 -------
Subject: Re:  java.util.TimeZone.getDefault() is broken

Hi,

On Thu, 2004-08-26 at 21:43, mckinlay at redhat dot com wrote:
> ------- Additional Comments From mckinlay at redhat dot com  2004-08-26 19:43 -------
> Unfortunately, this isn't yet fixed for some platforms, such as Fedora Core 2. 
> 
> FC2 does not set the TZ environment variable, and it does not have an
> /etc/timezone file. 

Even so, if the system property user.timezone isn't set, the TZ
environment variable isn't set, there isn't a /etc/timezone, and not
/etc/localtime then we still have the libc/posix way of getting the time
zone information.

> Here's the test case:
> 
> import java.util.TimeZone;
> 
> public class TZ2
> {
>   public static void main(String[] args)
>   {
>     TimeZone tz = TimeZone.getDefault();
>     System.out.println (tz.getID());
>   }
> }
> 
> $ java TZ2
> America/Toronto
> 
> $ gij TZ2
> EST

Isn't EST correct for Toronto?
You only print the ID not the whole timezone information. Please check
all information of the given timezone and see if any of that information
is incorrect for you system.

Maybe you think that the ID should be different but I think this is not
covered by this bug. Please see the TimeZone meta bug for an overview of
other issues with TimeZone [Bug libgcj/16990].

Thanks,

Mark


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-08-26 21:08 -------
Yes, afaik the other contents of the returned TimeZone are correct. However, as
an ID, "EST" is just a display name, it doesn't canonically identify any
particular time zone. Note that the spec says that the use of these three-letter
IDs to represent time zones is deprecated.

I agree that this is not the same issue as the original bug report, though. I'll
close this and file a new bug.

Thanks Mark

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2007-02-22 16:05 -------
Subject: Bug 17002

Author: jakub
Date: Thu Feb 22 16:04:55 2007
New Revision: 122229

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122229
Log:
libjava/
        PR libgcj/17002
        PR classpath/28550
        * java/util/VMTimeZone.java (getDefaultTimeZoneId): To read
        /etc/localtime, use ZoneInfo.readTZFile instead of
        VMTimeZone.readtzFile.  Get better timezone name for /etc/localtime,
        either if it is a symlink or through /etc/sysconfig/clock.
        (readSysconfigClockFile): New static method.
        (readtzFile): Removed.
        * java/lang/System.java: Add gnu.java.util.zoneinfo.dir to comments.
        * posix.cc (_Jv_platform_initProperties): Set
        gnu.java.util.zoneinfo.dir.
        * sources.am (gnu_java_util_source_files): Add
        classpath/gnu/java/util/ZoneInfo.java.
        * Makefile.in: Regenerated.
        * java/util/VMTimeZone.h: Regenerated.
        * java/util/TimeZone.h: Regenerated.
        * gnu/java/util/ZoneInfo.h: Generated.
libjava/classpath/
        * java/util/Date.java (parse): Properly parse 09:01:02 as
        hours/minutes/seconds, not as hours/minutes/year.
        * java/util/SimpleTimeZone.java (SimpleTimeZone): Simplify
        {start,end}TimeMode constructor by calling shorter constructor,
        set {start,end}TimeMode fields after it returns.
        (setStartRule): Don't adjust startTime into WALL_TIME.  Set
        startTimeMode to WALL_TIME.
        (endStartRule): Similarly.
        (getOffset): Handle properly millis + dstOffset overflowing into the
        next day.  Adjust startTime resp. endTime based on startTimeMode
        resp. endTimeMode.
        * java/util/TimeZone.java (zoneinfo_dir, availableIDs, aliases0): New
        static fields.
        (timezones): Remove synchronized keyword.  Set zoneinfo_dir.
        If non-null, set up aliases0 and don't put anything into
        timezones0.
        (defaultZone): Call getTimeZone instead of timezones().get.
        (getDefaultTimeZone): Fix parsing of EST5 or EST5EDT6.  Use
        getTimeZoneInternal instead of timezones().get.
        (parseTime): Parse correctly hour:minute.
        (getTimeZoneInternal): New private method.
        (getTimeZone): Do the custom ID checking first, canonicalize
        ID for custom IDs as required by documentation.  Call
        getTimeZoneInternal to handle the rest.
        (getAvailableIDs(int)): Add locking.  Handle zoneinfo_dir != null.
        (getAvailableIDs(File,String,ArrayList)): New private method.
        (getAvailableIDs()): Add locking.  Handle zoneinfo_dir != null.
        * gnu/java/util/ZoneInfo.java: New file.

Added:
    trunk/libjava/classpath/gnu/java/util/ZoneInfo.java
    trunk/libjava/classpath/lib/gnu/java/util/ZoneInfo.class   (with props)
    trunk/libjava/gnu/java/util/ZoneInfo.h
Modified:
    trunk/libjava/ChangeLog
    trunk/libjava/Makefile.in
    trunk/libjava/classpath/ChangeLog
    trunk/libjava/classpath/java/util/Date.java
    trunk/libjava/classpath/java/util/SimpleTimeZone.java
    trunk/libjava/classpath/java/util/TimeZone.java
    trunk/libjava/classpath/lib/java/util/Date.class
    trunk/libjava/classpath/lib/java/util/SimpleTimeZone.class
    trunk/libjava/classpath/lib/java/util/TimeZone$1.class
    trunk/libjava/classpath/lib/java/util/TimeZone.class
    trunk/libjava/classpath/lib/java/util/VMTimeZone.class
    trunk/libjava/java/lang/System.java
    trunk/libjava/java/util/TimeZone.h
    trunk/libjava/java/util/VMTimeZone.h
    trunk/libjava/java/util/VMTimeZone.java
    trunk/libjava/posix.cc
    trunk/libjava/sources.am

Propchange: trunk/libjava/classpath/lib/gnu/java/util/ZoneInfo.class
            ('svn:mime-type' added)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[gary at gcc dot gnu dot org]

------- Comment #7 from gary at gcc dot gnu dot org  2007-02-23 15:13 -------
Subject: Bug 17002

Author: gary
Date: Fri Feb 23 15:13:18 2007
New Revision: 122258

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122258
Log:
2007-02-22  Jakub Jelinek  <jakub@redhat.com>

        PR libgcj/17002
        PR classpath/28550
        * java/util/VMTimeZone.java (getDefaultTimeZoneId): To read
        /etc/localtime, use ZoneInfo.readTZFile instead of
        VMTimeZone.readtzFile.  Get better timezone name for /etc/localtime,
        either if it is a symlink or through /etc/sysconfig/clock.
        (readSysconfigClockFile): New static method.
        (readtzFile): Removed.
        * java/lang/System.java: Add gnu.java.util.zoneinfo.dir to comments.
        * posix.cc (_Jv_platform_initProperties): Set
        gnu.java.util.zoneinfo.dir.
        * sources.am (gnu_java_util_source_files): Add
        classpath/gnu/java/util/ZoneInfo.java.
        * Makefile.in: Regenerated.
        * java/util/VMTimeZone.h: Regenerated.
        * java/util/TimeZone.h: Regenerated.
        * gnu/java/util/ZoneInfo.h: Generated.


Modified:
    trunk/libjava/classpath/lib/gnu/java/util/ZoneInfo.class
    trunk/libjava/classpath/lib/java/lang/System$EnvironmentCollection.class
    trunk/libjava/classpath/lib/java/lang/System$EnvironmentMap.class
    trunk/libjava/classpath/lib/java/lang/System$EnvironmentSet.class
    trunk/libjava/classpath/lib/java/lang/System.class
    trunk/libjava/classpath/lib/java/util/Date.class
    trunk/libjava/classpath/lib/java/util/GregorianCalendar.class
    trunk/libjava/classpath/lib/java/util/SimpleTimeZone.class
    trunk/libjava/classpath/lib/java/util/TimeZone$1.class
    trunk/libjava/classpath/lib/java/util/TimeZone.class
    trunk/libjava/classpath/lib/java/util/VMTimeZone.class


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[cvs-commit at developer dot classpath dot org]

------- Comment #8 from cvs-commit at developer dot classpath dot org  2007-02-23 15:50 -------
Subject: Bug 17002

CVSROOT:        /cvsroot/classpath
Module name:    classpath
Changes by:     Gary Benson <gbenson>   07/02/23 15:50:04

Modified files:
        .              : ChangeLog NEWS 
        java/lang      : System.java 
        java/util      : Date.java SimpleTimeZone.java TimeZone.java 
        vm/reference/java/util: VMTimeZone.java 
Added files:
        gnu/java/util  : ZoneInfo.java 

Log message:
        2007-02-23  Gary Benson  <gbenson@redhat.com>
                    Jakub Jelinek  <jakub@redhat.com>

                PR libgcj/17002
                PR classpath/28550
                * java/util/Date.java (parse): Properly parse 09:01:02 as
                hours/minutes/seconds, not as hours/minutes/year.
                * java/util/SimpleTimeZone.java (SimpleTimeZone): Simplify
                {start,end}TimeMode constructor by calling shorter constructor,
                set {start,end}TimeMode fields after it returns.
                (setStartRule): Don't adjust startTime into WALL_TIME.  Set
                startTimeMode to WALL_TIME.
                (endStartRule): Similarly.
                (getOffset): Handle properly millis + dstOffset overflowing
into the
                next day.  Adjust startTime resp. endTime based on
startTimeMode
                resp. endTimeMode.
                * java/util/TimeZone.java (zoneinfo_dir, availableIDs,
aliases0): New
                static fields.
                (timezones): Remove synchronized keyword.  Set zoneinfo_dir.
                If non-null, set up aliases0 and don't put anything into
                timezones0.
                (defaultZone): Call getTimeZone instead of timezones().get.
                (getDefaultTimeZone): Fix parsing of EST5 or EST5EDT6.  Use
                getTimeZoneInternal instead of timezones().get.
                (parseTime): Parse correctly hour:minute.
                (getTimeZoneInternal): New private method.
                (getTimeZone): Do the custom ID checking first, canonicalize
                ID for custom IDs as required by documentation.  Call
                getTimeZoneInternal to handle the rest.
                (getAvailableIDs(int)): Add locking.  Handle zoneinfo_dir !=
null.
                (getAvailableIDs(File,String,ArrayList)): New private method.
                (getAvailableIDs()): Add locking.  Handle zoneinfo_dir != null.
                * vm/reference/java/util/VMTimeZone.java
(getDefaultTimeZoneId):
                To read /etc/localtime, use ZoneInfo.readTZFile instead of
                VMTimeZone.readtzFile.  Get better timezone name for
                /etc/localtime, either if it is a symlink or through
                /etc/sysconfig/clock.
                (readSysconfigClockFile): New static method.
                (readtzFile): Removed.
                * gnu/java/util/ZoneInfo.java: New file.        
                * java/lang/System.java: Add gnu.java.util.zoneinfo.dir to
comments.
                * NEWS: Documented TimeZone interface changes.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpath&r1=1.9128&r2=1.9129
http://cvs.savannah.gnu.org/viewcvs/classpath/NEWS?cvsroot=classpath&r1=1.177&r2=1.178
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/util/ZoneInfo.java?cvsroot=classpath&rev=1.1
http://cvs.savannah.gnu.org/viewcvs/classpath/java/lang/System.java?cvsroot=classpath&r1=1.59&r2=1.60
http://cvs.savannah.gnu.org/viewcvs/classpath/java/util/Date.java?cvsroot=classpath&r1=1.25&r2=1.26
http://cvs.savannah.gnu.org/viewcvs/classpath/java/util/SimpleTimeZone.java?cvsroot=classpath&r1=1.31&r2=1.32
http://cvs.savannah.gnu.org/viewcvs/classpath/java/util/TimeZone.java?cvsroot=classpath&r1=1.36&r2=1.37
http://cvs.savannah.gnu.org/viewcvs/classpath/vm/reference/java/util/VMTimeZone.java?cvsroot=classpath&r1=1.4&r2=1.5


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002

[Bug libgcj/17002] java.util.TimeZone.getDefault() is broken

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2007-06-22 12:17 -------
Subject: Bug 17002

Author: jakub
Date: Fri Jun 22 12:17:00 2007
New Revision: 125946

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125946
Log:
2007-02-24  Jakub Jelinek  <jakub@redhat.com>

libjava/classpath/
        * java/util/TimeZone.java (getDefaultDisplayName): Don't
        check if TimeZone is instanceof SimpleTimeZone.

2007-02-22  Jakub Jelinek  <jakub@redhat.com>

libjava/
        PR libgcj/17002
        PR classpath/28550
        * java/util/VMTimeZone.java (getDefaultTimeZoneId): To read
        /etc/localtime, use ZoneInfo.readTZFile instead of
        VMTimeZone.readtzFile.  Get better timezone name for /etc/localtime,
        either if it is a symlink or through /etc/sysconfig/clock.
        (readSysconfigClockFile): New static method.
        (readtzFile): Removed.
        * java/lang/System.java: Add gnu.java.util.zoneinfo.dir to comments.
        * posix.cc (_Jv_platform_initProperties): Set
        gnu.java.util.zoneinfo.dir.
        * sources.am (gnu_java_util_source_files): Add
        classpath/gnu/java/util/ZoneInfo.java.
        * Makefile.in: Regenerated.
libjava/classpath/
        * java/util/Date.java (parse): Properly parse 09:01:02 as
        hours/minutes/seconds, not as hours/minutes/year.
        * java/util/SimpleTimeZone.java (SimpleTimeZone): Simplify
        {start,end}TimeMode constructor by calling shorter constructor,
        set {start,end}TimeMode fields after it returns.
        (setStartRule): Don't adjust startTime into WALL_TIME.  Set
        startTimeMode to WALL_TIME.
        (endStartRule): Similarly.
        (getOffset): Handle properly millis + dstOffset overflowing into the
        next day.  Adjust startTime resp. endTime based on startTimeMode
        resp. endTimeMode.
        * java/util/TimeZone.java (zoneinfo_dir, availableIDs, aliases0): New
        static fields.
        (timezones): Remove synchronized keyword.  Set zoneinfo_dir.
        If non-null, set up aliases0 and don't put anything into
        timezones0.
        (defaultZone): Call getTimeZone instead of timezones().get.
        (getDefaultTimeZone): Fix parsing of EST5 or EST5EDT6.  Use
        getTimeZoneInternal instead of timezones().get.
        (parseTime): Parse correctly hour:minute.
        (getTimeZoneInternal): New private method.
        (getTimeZone): Do the custom ID checking first, canonicalize
        ID for custom IDs as required by documentation.  Call
        getTimeZoneInternal to handle the rest.
        (getAvailableIDs(int)): Add locking.  Handle zoneinfo_dir != null.
        (getAvailableIDs(File,String,ArrayList)): New private method.
        (getAvailableIDs()): Add locking.  Handle zoneinfo_dir != null.
        * gnu/java/util/ZoneInfo.java: New file.

2007-02-14  Jakub Jelinek  <jakub@redhat.com>
        Andrew Haley  <aph@redhat.com>

libjava/classpath/
        * java/util/TimeZone.java (getDateParams): Negate dayOfWeek.

2007-02-09  Jakub Jelinek  <jakub@redhat.com>

libjava/
        * java/util/VMTimeZone.java: Rewrite to handle both the old
        'TZif\0' format and the new one.
libjava/classpath/
        * java/util/TimeZone.java: Handle default (one hour) daylight
        savings.

        PR 23566
        * java/util/TimeZone.java (timezones): Regenerate from tzdata2007a.

Added:
   
branches/redhat/fc6-4_1-branch/libjava/classpath/gnu/java/util/ZoneInfo.java
Modified:
    branches/redhat/fc6-4_1-branch/libjava/ChangeLog
    branches/redhat/fc6-4_1-branch/libjava/Makefile.in
    branches/redhat/fc6-4_1-branch/libjava/classpath/ChangeLog
    branches/redhat/fc6-4_1-branch/libjava/classpath/java/util/Date.java
   
branches/redhat/fc6-4_1-branch/libjava/classpath/java/util/SimpleTimeZone.java
    branches/redhat/fc6-4_1-branch/libjava/classpath/java/util/TimeZone.java
    branches/redhat/fc6-4_1-branch/libjava/java/lang/System.java
    branches/redhat/fc6-4_1-branch/libjava/java/util/VMTimeZone.java
    branches/redhat/fc6-4_1-branch/libjava/posix.cc
    branches/redhat/fc6-4_1-branch/libjava/sources.am


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17002