public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug java/17265] [3.5 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
@ 2004-09-01 19:25 ` mckinlay at redhat dot com
  2004-09-01 19:27 ` mckinlay at redhat dot com
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: mckinlay at redhat dot com @ 2004-09-01 19:25 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From mckinlay at redhat dot com  2004-09-01 19:25 -------
It sounds like 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |java-prs at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [3.5 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
  2004-09-01 19:25 ` [Bug java/17265] [3.5 Regression] Libjava doesn't build mckinlay at redhat dot com
@ 2004-09-01 19:27 ` mckinlay at redhat dot com
  2004-09-12  1:37 ` pinskia at gcc dot gnu dot org
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: mckinlay at redhat dot com @ 2004-09-01 19:27 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From mckinlay at redhat dot com  2004-09-01 19:27 -------
... sounds like ASM_OUTPUT_DEF isn't working correctly with the solaris
assembler. Please try --save-temps and post the .s output.

My guess is that Solaris needs to be fixed to not define ASM_OUTPUT_DEF if the
assembler doesn't support it.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [3.5 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
  2004-09-01 19:25 ` [Bug java/17265] [3.5 Regression] Libjava doesn't build mckinlay at redhat dot com
  2004-09-01 19:27 ` mckinlay at redhat dot com
@ 2004-09-12  1:37 ` pinskia at gcc dot gnu dot org
  2004-09-12  8:42 ` ebotcazou at gcc dot gnu dot org
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-09-12  1:37 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-12 01:37 -------
We really need the assembly file to go any further on this bug.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [3.5 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (2 preceding siblings ...)
  2004-09-12  1:37 ` pinskia at gcc dot gnu dot org
@ 2004-09-12  8:42 ` ebotcazou at gcc dot gnu dot org
  2004-09-13  5:35 ` rth at gcc dot gnu dot org
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2004-09-12  8:42 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-09-12 08:42 -------
> ... sounds like ASM_OUTPUT_DEF isn't working correctly with the solaris
> assembler. Please try --save-temps and post the .s output.

You correctly guessed, it's related to ASM_OUTPUT_DEF and aliases.

> My guess is that Solaris needs to be fixed to not define ASM_OUTPUT_DEF if the
> assembler doesn't support it.

The Solaris assembler does support equates (hey! it is not that primitive :-)
but the equated symbol must be defined somewhere in the file. Here we have both

.LL_ZN4java4lang5Class23getDeclaredConstructorsEv13 =
_ZN4java4lang5Class23getDeclaredConstructorsEv

which assembles fine because the second symbol is defined as

	.global _ZN4java4lang5Class23getDeclaredConstructorsEv
	.type	_ZN4java4lang5Class23getDeclaredConstructorsEv, #function
	.proc	0110
_ZN4java4lang5Class23getDeclaredConstructorsEv:

and

.LL_ZN4java4lang5Class17getDeclaringClassEv20 =
_ZN4java4lang5Class17getDeclaringClassEv

which doesn't because the second symbol is not defined in the file.


I can think of two explanations:
- the aliased method should have been defined in the assembly file but for some
reason it would not have been used, so the compiler decided to not emit it
altogether,
- the new code in class.c is somehow abusing the notion of "alias" as it
attempts to contruct a local alias of an external function.

In the first case, the fix could be to defer the call to assemble_alias until
after we know that the method will be emitted; in the second case, the fix could
be to add yet another target macro and to guard the new code with it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2004-09-01 18:59:04         |2004-09-12 08:42:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [3.5 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (3 preceding siblings ...)
  2004-09-12  8:42 ` ebotcazou at gcc dot gnu dot org
@ 2004-09-13  5:35 ` rth at gcc dot gnu dot org
  2004-10-07  9:51 ` [Bug java/17265] [4.0 " ebotcazou at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: rth at gcc dot gnu dot org @ 2004-09-13  5:35 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From rth at gcc dot gnu dot org  2004-09-13 05:35 -------
Note that while this construct is *accepted* by gas, it won't do what
you might think it would.  It does nothing useful.  I've wished in the
past that gas would diagnose this problem...

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (4 preceding siblings ...)
  2004-09-13  5:35 ` rth at gcc dot gnu dot org
@ 2004-10-07  9:51 ` ebotcazou at gcc dot gnu dot org
  2004-10-09 16:09 ` ebotcazou at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2004-10-07  9:51 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-10-07 09:51 -------
Not much progress.  As per RTH's comment, I'll prepare a patch to revert the
faulty bits.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (5 preceding siblings ...)
  2004-10-07  9:51 ` [Bug java/17265] [4.0 " ebotcazou at gcc dot gnu dot org
@ 2004-10-09 16:09 ` ebotcazou at gcc dot gnu dot org
  2004-10-19 16:49 ` ebotcazou at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2004-10-09 16:09 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-10-09 16:09 -------
Reverting the change in class.c lets the library build, but only to stumble upon
another problem:

/opt/build/eric/gcc/gcc/gcj -B/opt/build/eric/gcc/gcc/
-B/opt/build/eric/local/gcc-4.0/sparc-sun-solaris2.8/bin/
-B/opt/build/eric/local/gcc-4.0/sparc-sun-solaris2.8/lib/ -isystem
/opt/build/eric/local/gcc-4.0/sparc-sun-solaris2.8/include -isystem
/opt/build/eric/local/gcc-4.0/sparc-sun-solaris2.8/sys-include -m64 -g -O2 -m64
-m64 -o .libs/jv-convert --main=gnu.gcj.convert.Convert -shared-libgcc 
-L/opt/build/eric/gcc/sparc-sun-solaris2.8/sparcv9/libjava
-L/opt/build/eric/gcc/sparc-sun-solaris2.8/sparcv9/libjava/.libs
./.libs/libgcj.so
-L/opt/build/eric/gcc/sparc-sun-solaris2.8/sparcv9/libstdc++-v3/src
-L/opt/build/eric/gcc/sparc-sun-solaris2.8/sparcv9/libstdc++-v3/src/.libs
-lpthread -lrt -ldl -L/opt/build/eric/gcc/gcc/sparcv9 -L/opt/build/eric/gcc/gcc
-L/usr/ccs/bin/sparcv9 -L/usr/ccs/bin -L/usr/ccs/lib/sparcv9 -L/usr/ccs/lib
-L/lib/sparcv9 -L/usr/lib/sparcv9 -lgcc_s_sparcv9 -lgcc_s_sparcv9 -Wl,-R
-Wl,/opt/build/eric/local/gcc-4.0/lib/sparcv9
ld: warning: file
/opt/build/eric/gcc/sparc-sun-solaris2.8/sparcv9/libjava/.libs/libgcj.so: linked
to ./.libs/libgcj.so: attempted multiple inclusion of file
ld: warning: file
/opt/build/eric/gcc/sparc-sun-solaris2.8/sparcv9/libjava/.libs/libgcj.so: linked
to ./.libs/libgcj.so: attempted multiple inclusion of file
Undefined                       first referenced
 symbol                             in file
java::lang::Class::isPrimitive()    ./.libs/libgcj.so
java::lang::Class::getSuperclass()   ./.libs/libgcj.so
_Jv_InitClass                       ./.libs/libgcj.so
java::lang::Class::isArray()        ./.libs/libgcj.so
java::lang::Class::getComponentType()   ./.libs/libgcj.so
java::lang::Class::isInterface()    ./.libs/libgcj.so
__gxx_personality_v0                ./.libs/libgcj.so
java::lang::Class::getModifiers()   ./.libs/libgcj.so
ld: fatal: Symbol referencing errors. No output written to .libs/jv-convert
collect2: ld returned 1 exit status
gmake[4]: *** [jv-convert] Error 1

I'll try to revert the whole patch tomorrow.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (6 preceding siblings ...)
  2004-10-09 16:09 ` ebotcazou at gcc dot gnu dot org
@ 2004-10-19 16:49 ` ebotcazou at gcc dot gnu dot org
  2004-10-19 16:51 ` pinskia at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2004-10-19 16:49 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-10-19 16:48 -------
Reverting the parse.y changes doesn't help.  The problem is that the inline
methods defined in java/lang/class.h are not emitted in natClass.o, despite the
presence of

#pragma implementation "Class.h"

at the beginning of the file.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (7 preceding siblings ...)
  2004-10-19 16:49 ` ebotcazou at gcc dot gnu dot org
@ 2004-10-19 16:51 ` pinskia at gcc dot gnu dot org
  2004-10-20 11:59 ` ebotcazou at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-19 16:51 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-19 16:51 -------
That sounds like C++ bug.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (8 preceding siblings ...)
  2004-10-19 16:51 ` pinskia at gcc dot gnu dot org
@ 2004-10-20 11:59 ` ebotcazou at gcc dot gnu dot org
  2004-10-22 14:30 ` cvs-commit at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2004-10-20 11:59 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-10-20 11:59 -------
> That sounds like C++ bug.

Indeed, relating to the handling of #pragma (PR c++/18075).


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |18075


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (9 preceding siblings ...)
  2004-10-20 11:59 ` ebotcazou at gcc dot gnu dot org
@ 2004-10-22 14:30 ` cvs-commit at gcc dot gnu dot org
  2004-10-27 17:32 ` zack at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-22 14:30 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-22 14:30 -------
Subject: Bug 17265

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	ebotcazou@gcc.gnu.org	2004-10-22 14:30:37

Modified files:
	gcc/java       : ChangeLog class.c 

Log message:
	PR java/17265
	* class.c (make_local_function_alias): Revert 2004-08-18 change.
	(make_method_value): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1490&r2=1.1491
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/class.c.diff?cvsroot=gcc&r1=1.211&r2=1.212



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (10 preceding siblings ...)
  2004-10-22 14:30 ` cvs-commit at gcc dot gnu dot org
@ 2004-10-27 17:32 ` zack at gcc dot gnu dot org
  2004-10-27 17:45 ` ebotcazou at gcc dot gnu dot org
  2004-11-02 16:53 ` cvs-commit at gcc dot gnu dot org
  13 siblings, 0 replies; 14+ messages in thread
From: zack at gcc dot gnu dot org @ 2004-10-27 17:32 UTC (permalink / raw)
  To: java-prs



-- 
Bug 17265 depends on bug 18075, which changed state.

Bug 18075 Summary: [4.0 Regression] #pragma implementation broken in presence of #pragma ident
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18075

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (11 preceding siblings ...)
  2004-10-27 17:32 ` zack at gcc dot gnu dot org
@ 2004-10-27 17:45 ` ebotcazou at gcc dot gnu dot org
  2004-11-02 16:53 ` cvs-commit at gcc dot gnu dot org
  13 siblings, 0 replies; 14+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2004-10-27 17:45 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-10-27 17:45 -------
Libjava builds for me now on sparc64-sun-solaris2.9 and sparc-sun-solaris2.8. 
Testsuite results are decent (42 and 24 failures respectively).


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug java/17265] [4.0 Regression] Libjava doesn't build
       [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
                   ` (12 preceding siblings ...)
  2004-10-27 17:45 ` ebotcazou at gcc dot gnu dot org
@ 2004-11-02 16:53 ` cvs-commit at gcc dot gnu dot org
  13 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-11-02 16:53 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-11-02 16:52 -------
Subject: Bug 17265

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bryce@gcc.gnu.org	2004-11-02 16:52:55

Modified files:
	gcc/java       : ChangeLog class.c 

Log message:
	2004-11-02  Bryce McKinlay  <mckinlay@redhat.com>
	
	PR java/17265
	* class.c: Reinstate 2004-08-18 patch.
	(make_local_function_alias): Don't create an alias for extern (native)
	functions.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1491&r2=1.1492
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/class.c.diff?cvsroot=gcc&r1=1.212&r2=1.213



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17265


^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2004-11-02 16:53 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20040901184813.17265.ebotcazou@gcc.gnu.org>
2004-09-01 19:25 ` [Bug java/17265] [3.5 Regression] Libjava doesn't build mckinlay at redhat dot com
2004-09-01 19:27 ` mckinlay at redhat dot com
2004-09-12  1:37 ` pinskia at gcc dot gnu dot org
2004-09-12  8:42 ` ebotcazou at gcc dot gnu dot org
2004-09-13  5:35 ` rth at gcc dot gnu dot org
2004-10-07  9:51 ` [Bug java/17265] [4.0 " ebotcazou at gcc dot gnu dot org
2004-10-09 16:09 ` ebotcazou at gcc dot gnu dot org
2004-10-19 16:49 ` ebotcazou at gcc dot gnu dot org
2004-10-19 16:51 ` pinskia at gcc dot gnu dot org
2004-10-20 11:59 ` ebotcazou at gcc dot gnu dot org
2004-10-22 14:30 ` cvs-commit at gcc dot gnu dot org
2004-10-27 17:32 ` zack at gcc dot gnu dot org
2004-10-27 17:45 ` ebotcazou at gcc dot gnu dot org
2004-11-02 16:53 ` cvs-commit at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).