[Bug libgcj/17978] New: Binary Compatibility: use _Jv_AllocBytes to allocate interface dispatch tables

[Bug libgcj/17978] New: Binary Compatibility: use _Jv_AllocBytes to allocate interface dispatch tables

[tromey at gcc dot gnu dot org]

On the BC branch, in link.cc, there are a number of
places where we use _Jv_Malloc where we ought to use
_Jv_AllocBytes.  Search for the FIXME comments
(not every malloc needs to be replaced).

Actually doing this results in a buggy runtime, however.
There is probably some GC marking problem, however boehm.cc already
appears to mark the needed fields, so the exact problem
remains unknown.

-- 
           Summary: Binary Compatibility: use _Jv_AllocBytes to allocate
                    interface dispatch tables
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tromey at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
OtherBugsDependingO 12725
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17978

[Bug libgcj/17978] Binary Compatibility: use _Jv_AllocBytes to allocate interface dispatch tables

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-24 19:18 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-11-24 19:18:27
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17978

[Bug libgcj/17978] Binary Compatibility: use _Jv_AllocBytes to allocate interface dispatch tables

[tromey at gcc dot gnu dot org]

------- Comment #4 from tromey at gcc dot gnu dot org  2006-02-08 20:09 -------
Fix checked in.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17978

[Bug libgcj/17978] Binary Compatibility: use _Jv_AllocBytes to allocate interface dispatch tables

[tromey at gcc dot gnu dot org]

------- Comment #3 from tromey at gcc dot gnu dot org  2006-02-08 20:07 -------
Subject: Bug 17978

Author: tromey
Date: Wed Feb  8 20:07:29 2006
New Revision: 110763

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110763
Log:
        PR libgcj/26063, PR libgcj/17978, PR libgcj/10598:
        * defineclass.cc (parse): Use _Jv_AllocRawObj.
        (read_constpool): Likewise.
        (read_one_code_attribute): Use internal function name.
        (handleConstantPool): Use _Jv_AllocRawObj.
        (handleInterfacesBegin): Likewise.
        (handleFieldsBegin): Likewise.
        (handleMethodsBegin): Likewise.
        (handleCodeAttribute): Likewise.
        (handleMethodsEnd): Likewise.
        * include/jvm.h (new_vtable): Use _Jv_AllocRawObj.
        * interpret.cc (do_allocate_static_fields): Use _Jv_AllocRawObj.
        Allocate reference fields separately.
        * link.cc (prepare_constant_time_tables): Use _Jv_AllocRawObj.
        (add_miranda_methods): Likewise.
        (generate_itable): Use _Jv_AllocBytes.
        (find_iindex): Likewise.
        (struct method_closure): New structure.
        (create_error_method): Use struct method_closure; allocate with
        _Jv_AllocBytes.
        (ensure_fields_laid_out): Separate reference fields from
        non-reference fields.
        * boehm.cc (_Jv_MarkObj): Mark vtable.  Only mark direct fields
        of Class.
        (_Jv_MarkArray): Mark vtable.
        (_Jv_AllocRawObj): Don't allocate objects of size 0.
        * include/execution.h
        (_Jv_ExecutionEngine::allocate_static_fields): Added 'int'
        parameter.
        (struct _Jv_CompiledEngine): Updated.
        (class _Jv_InterpreterEngine): Updated.

Modified:
    trunk/libjava/ChangeLog
    trunk/libjava/boehm.cc
    trunk/libjava/defineclass.cc
    trunk/libjava/include/execution.h
    trunk/libjava/include/jvm.h
    trunk/libjava/interpret.cc
    trunk/libjava/link.cc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17978

[Bug libgcj/17978] Binary Compatibility: use _Jv_AllocBytes to allocate interface dispatch tables

[tromey at gcc dot gnu dot org]

------- Comment #2 from tromey at gcc dot gnu dot org  2006-02-04 22:29 -------
Testing a patch.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-07-18 01:34:51         |2006-02-04 22:29:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17978