[Bug java/19907] Incorrect code generated for ManifestElement.java

[Bug java/19907] Incorrect code generated for ManifestElement.java

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2005-02-11 16:37 -------
Created an attachment (id=8177)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8177&action=view)
ManifestElement.class


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] New: Incorrect code generated for ManifestElement.java

[aph at gcc dot gnu dot org]

The bytecode compiler generates incorrect code for the attached .class file.

-- 
           Summary: Incorrect code generated for ManifestElement.java
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: aph at gcc dot gnu dot org
        ReportedBy: aph at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] Incorrect code generated for ManifestElement.java

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2005-02-11 16:41 -------
The method ArrayList.add() return a boolean, so the bytecode compiler generates
a temp of type promoted_boolean.  Unfortunately, the same temp is used later as
an int.

This problem arises because promoted booleans in the Java VM are really an
integer type, not a boolean type.  It's perfectly legal to store a boolean and
then read an int for the same slot.  So, we need to use int temporaries for
booleans, not promoted_boolean.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-02-11 16:41:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] Incorrect code generated for ManifestElement.java

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-11 20:50 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00521.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |patch, wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] Incorrect code generated for ManifestElement.java

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-02-11 20:56 -------
*** Bug 19834 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mckinlay at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] Incorrect code generated for ManifestElement.java

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2005-02-12 13:29 -------
The patch I submitted is inadequate.  I know how to fix it, and I'll resubmit.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] Incorrect code generated for ManifestElement.java

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-14 14:58 -------
Subject: Bug 19907

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aph@gcc.gnu.org	2005-02-14 14:58:23

Modified files:
	gcc/java       : ChangeLog expr.c decl.c 

Log message:
	2005-02-14  Andrew Haley  <aph@redhat.com>
	
	PR java/19907
	* expr.c (expand_byte_code): Call promote_arguments().
	(promote_arguments): New function.
	* decl.c (check_local_unnamed_variable): Remve special case for
	new verifier.
	(find_local_variable): Promote all boolean types to int
	when searching for local variable decls.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1550&r2=1.1551
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/expr.c.diff?cvsroot=gcc&r1=1.217&r2=1.218
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/decl.c.diff?cvsroot=gcc&r1=1.208&r2=1.209



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907

[Bug java/19907] Incorrect code generated for ManifestElement.java

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-14 15:16 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19907