[Bug libgcj/21140] New: Charset.encode and Charset.decode broken

[Bug libgcj/21140] New: Charset.encode and Charset.decode broken

[luca dot barbieri at gmail dot com]

Charset.encode and Charset.decode only work for a single call.

The reason is that the encoder/decoder is cached and after the first call it
will be in the flushed state.

The second call will thus throw an InvalidStateException.

Removing the cache or resetting the cached object should solve this.

-- 
           Summary: Charset.encode and Charset.decode broken
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: luca dot barbieri at gmail dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] Charset.encode and Charset.decode broken

[konqueror at gmx dot de]

------- Additional Comments From konqueror at gmx dot de  2005-04-21 05:28 -------
This bug is fixed in GNU classpath and I will merge the needed fixes soon. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-04-21 05:28:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] Charset.encode and Charset.decode broken

[konqueror at gmx dot de]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |konqueror at gmx dot de
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] [4.0 only] Charset.encode and Charset.decode broken

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-28 02:23 -------
Fixed on the mainline by:
2005-04-27  Sven de Marothy  <sven@physto.se>

        * java/nio/charset/Charset.java: Cached encoders shouldn't be static.
        
2005-04-27  Sven de Marothy  <sven@physto.se> 

        * java/nio/charset/Charset.java: Reset cached de/encoders.

Hmm, I think these patches should be backported to 4.0.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
            Summary|Charset.encode and          |[4.0 only] Charset.encode
                   |Charset.decode broken       |and Charset.decode broken
   Target Milestone|---                         |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] [4.0 only] Charset.encode and Charset.decode broken

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2005-04-28 11:00 -------
Added to Tom Tromey's queue for 4.0 branch.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] [4.0 only] Charset.encode and Charset.decode broken

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-05-04 21:45 -------
Note that the patch from the trunk can't be applied to the 4.0
branch, as it would break compatibility for the C++ ABI.
My current leaning is to simply disable the caching in 4.0.1.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] [4.0 only] Charset.encode and Charset.decode broken

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-17 01:46 -------
Subject: Bug 21140

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tromey@gcc.gnu.org	2005-05-17 01:46:06

Modified files:
	libjava        : ChangeLog 
	libjava/java/nio/charset: Charset.java 

Log message:
	PR libgcj/21140:
	* java/nio/charset/Charset.java (encode, decode): Don't cache.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.69&r2=1.3391.2.70
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/nio/charset/Charset.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140

[Bug libgcj/21140] [4.0 only] Charset.encode and Charset.decode broken

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-05-17 01:50 -------
Fix checked in.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21140