[Bug libgcj/21136] tryLock waits for the lock, and lock doesn't

[Bug libgcj/21136] tryLock waits for the lock, and lock doesn't

[luca dot barbieri at gmail dot com]

------- Additional Comments From luca dot barbieri at gmail dot com  2005-04-21 00:25 -------
Created an attachment (id=8693)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8693&action=view)
Patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] New: tryLock waits for the lock, and lock doesn't

[luca dot barbieri at gmail dot com]

In gnu.java.nio.channels.FileChannelImpl tryLock and lock call the native lock
functions with incorrect wait parameters: tryLock passes true and lock false.

Of course, tryLock should pass false and lock should pass true.

Patch attached.

-- 
           Summary: tryLock waits for the lock, and lock doesn't
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: luca dot barbieri at gmail dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
 GCC build triplet: i386-redhat-linux
  GCC host triplet: i386-redhat-linux
GCC target triplet: i386-redhat-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] tryLock waits for the lock, and lock doesn't

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-04-26 21:49 -------
Thanks, I checked in your fix to cvs trunk.
I put it on my list to consider for 4.0.1 as well.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] tryLock waits for the lock, and lock doesn't

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-26 21:49 -------
Subject: Bug 21136

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-04-26 21:49:24

Modified files:
	libjava        : ChangeLog 
	libjava/gnu/java/nio/channels: FileChannelImpl.java 

Log message:
	2005-04-26  Luca Barbieri  <luca.barbieri@gmail.com>
	
	PR libgcj/21136:
	* gnu/java/nio/channels/FileChannelImpl.java (tryLock): Pass
	'false' to native lock().
	(lock): Pass 'true' to native lock().

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3559&r2=1.3560
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/nio/channels/FileChannelImpl.java.diff?cvsroot=gcc&r1=1.8&r2=1.9



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] [4.0 only] tryLock waits for the lock, and lock doesn't

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-26 22:01 -------
(In reply to comment #2)
> Thanks, I checked in your fix to cvs trunk.
> I put it on my list to consider for 4.0.1 as well.
Lets reopen it then for now and mark it as "4.0 only"

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |
            Summary|tryLock waits for the lock, |[4.0 only] tryLock waits for
                   |and lock doesn't            |the lock, and lock doesn't
   Target Milestone|4.1.0                       |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] [4.0 only] tryLock waits for the lock, and lock doesn't

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/java-
                   |                            |patches/2005-
                   |                            |q2/msg00305.html
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |patch
      Known to fail|                            |4.0.0
      Known to work|                            |4.1.0
   Last reconfirmed|0000-00-00 00:00:00         |2005-04-26 22:03:23
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] [4.0 only] tryLock waits for the lock, and lock doesn't

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2005-04-28 10:59 -------
Added to Tom Tromey's queue for 4.0 branch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] [4.0 only] tryLock waits for the lock, and lock doesn't

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-29 18:40 -------
Subject: Bug 21136

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tromey@gcc.gnu.org	2005-04-29 18:40:00

Modified files:
	libjava        : ChangeLog 
	libjava/gnu/java/nio/channels: FileChannelImpl.java 

Log message:
	2005-04-26  Luca Barbieri  <luca.barbieri@gmail.com>
	
	PR libgcj/21136:
	* gnu/java/nio/channels/FileChannelImpl.java (tryLock): Pass
	'false' to native lock().
	(lock): Pass 'true' to native lock().

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.55&r2=1.3391.2.56
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/nio/channels/FileChannelImpl.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.7.4.1&r2=1.7.4.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136

[Bug libgcj/21136] [4.0 only] tryLock waits for the lock, and lock doesn't

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-04-29 18:41 -------
I checked this in on the 4.0 branch.
It will appear in 4.0.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21136