[Bug java/21844] New: miscompilation of LinkedHashMap

[Bug java/21844] New: miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

This happens with 4.1 but not with 4.0.x.
It occurs even without -O.

I believe java.util.LinkedHashMap is being miscompiled.
You can see this by trying the test case in PR 20273.
For me, it crashes.

In the debugger I observed that this line from
LinkedHashMap$LinkedHashEntry.access() is incrementing
the 'succ' field and not the modCount field:
          modCount++;

-- 
           Summary: miscompilation of LinkedHashMap
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tromey at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
 GCC build triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-03 20:02 -------
I have a reduced test case, consisting of 2 files.
Compile like so:

gcj --main=t -o T base.java t.java

I get:

opsy. ./T
306833

The result should be '8'.

At the moment I suspect the recent accessor patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-03 20:03 -------
Created an attachment (id=9023)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9023&action=view)
base class


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-03 20:03 -------
Created an attachment (id=9024)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9024&action=view)
main class


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] miscompilation of LinkedHashMap

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-06-03 20:11 -------
Hmm, inner functions going back again :(.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |18131
              nThis|                            |
           Keywords|                            |wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-06-03 20:14 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
      Known to fail|                            |4.1.0
      Known to work|                            |4.0.0
   Last reconfirmed|0000-00-00 00:00:00         |2005-06-03 20:14:34
               date|                            |
            Summary|miscompilation of           |[4.1 Regression]
                   |LinkedHashMap               |miscompilation of
                   |                            |LinkedHashMap
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-03 21:17 -------
The problem is that nested_field_access_p() returns 0 for the
reference to modCount.  It should return 1 as this is a nested
access.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-03 22:03 -------
I'm testing a patch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-06-03 20:14:34         |2005-06-03 22:03:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-13 19:20 -------
Subject: Bug 21844

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-06-13 19:20:26

Modified files:
	gcc/java       : ChangeLog parse.y 

Log message:
	PR java/21844:
	* parse.y (nested_field_access_p): Handle case where outer field
	is inherited by enclosing class.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1626&r2=1.1627
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&r1=1.538&r2=1.539



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-13 19:22 -------
Subject: Bug 21844

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-06-13 19:21:56

Modified files:
	libjava        : ChangeLog 
Added files:
	libjava/testsuite/libjava.lang: pr21844.java pr21844.out 

Log message:
	PR java/21844:
	* testsuite/libjava.lang/pr21844.java: New file.
	* testsuite/libjava.lang/pr21844.out: New file.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3658&r2=1.3659
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/pr21844.java.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/pr21844.out.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844

[Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-13 19:23 -------
I've checked in the fix.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844