[Bug java/23891] New: Problem folding static fields across packages

[Bug java/23891] New: Problem folding static fields across packages

[mckinlay at redhat dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

The following test case, derived from Eclipse/ecj, fails to compile on HEAD and
current 4.0 branch. This is a regression since 4.0.0.

package ast;

import classfmt.*;
public abstract class ASTNode implements ClassFileConstants {
}

---

package ast;

public class EqualExpression extends ASTNode {
        public void resolveType() {
                long foo = JDK1_5;
        }
}

---

package classfmt;

public interface ClassFileConstants {
        int MINOR_VERSION_0 = 0;
        long JDK1_5 = (long) ClassFileConstants.MINOR_VERSION_0;
}


$ gcj -c ast/EqualExpression.java
./classfmt/ClassFileConstants.java: In class 'ast.EqualExpression':
./classfmt/ClassFileConstants.java: In method 'ast.EqualExpression.resolveType()':
./classfmt/ClassFileConstants.java:5: error: Undefined variable or class name:
‘ClassFileConstants.MINOR_VERSION_0’.
        long JDK1_5 = (long) ClassFileConstants.MINOR_VERSION_0;
                                ^
1 error

-- 
           Summary: Problem folding static fields across packages
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mckinlay at redhat dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] Problem folding static fields across packages

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-09-15 00:08 -------
The problem is that fold_constant_for_init() saves the current_class state when
 resolving other dependent constants, but not the current package
(ctxp->package). If a constant in another package is referenced, then when
resolving/folding the value of that constant, the wrong package context is used.

I'm testing a patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mckinlay at redhat dot com
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-09-15 00:08:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] Problem folding static fields across packages

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-15 14:13 -------
Subject: Bug 23891

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bryce@gcc.gnu.org	2005-09-15 14:13:06

Modified files:
	gcc/java       : ChangeLog java-tree.h jcf-parse.c parse.y 

Log message:
	2005-09-14  Bryce McKinlay  <mckinlay@redhat.com>
	
	PR java/23891
	* parse.y (maybe_create_class_interface_decl): Set TYPE_PACKAGE for
	the newly created type. Set import lists here, not in create_class.
	(jdep_resolve_class): Set current_class.
	(do_resolve_class): Use current_class's TYPE_PACKAGE to determine
	the current package context, not ctxp->package.
	(cicp_cache): Removed.
	(class_in_current_package): Simplify implementation using
	TYPE_PACKAGE.
	* jcf-parse.c (give_name_to_class): Set TYPE_PACKAGE.
	* java-tree.h (TYPE_PACKAGE): New macro.
	(struct lang_type): New member 'package'.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1663&r2=1.1664
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/java-tree.h.diff?cvsroot=gcc&r1=1.243&r2=1.244
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/jcf-parse.c.diff?cvsroot=gcc&r1=1.188&r2=1.189
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&r1=1.554&r2=1.555



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] Problem folding static fields across packages

[mckinlay at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] Problem folding static fields across packages

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-09-15 14:19 -------
Fixed checked in to HEAD, but this should also be applied to 4.0 branch because
its a regression from 4.0.0.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] [4.0 Regression] Problem folding static fields across packages

[debian-gcc at lists dot debian dot org]

------- Additional Comments From debian-gcc at lists dot debian dot org  2005-09-16 20:05 -------
the patch, when applied to the 4.0 branch, let the bootstrap fail in libjava on
at least i486-linux and ia64-linux

  Matthias

/home/packages/gcc/4.0/gcc-4.0-4.0.1/build/gcc/gcj
-B/home/packages/gcc/4.0/gcc-4.0-4.0.1/build/gcc/ -B/usr/i486-linux-gnu/bin/
-B/usr/i486-linux-gnu/lib/ -isystem /usr/i486-linux-gnu/include -isystem
/usr/i486-linux-gnu/sys-include --encoding=UTF-8 -Wno-deprecated -C -g
-classpath '' -bootclasspath
/home/packages/gcc/4.0/gcc-4.0-4.0.1/build/i486-linux-gnu/libjava':'../../../src/libjava':'../../../src/libjava/external/w3c_dom':'../../../src/libjava/external/sax
-d /home/packages/gcc/4.0/gcc-4.0-4.0.1/build/i486-linux-gnu/libjava \
        -MD -MF gnu/java/security/util.deps @gnu/java/security/util.list
../../../src/libjava/java/io/ObjectStreamClass.java:930: internal compiler
error: Segmentation
fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |debian-gcc at lists dot
                   |                            |debian dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] [4.0 Regression] Problem folding static fields across packages

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-21 13:45 -------
Subject: Bug 23891

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	rmathew@gcc.gnu.org	2005-09-21 13:45:22

Modified files:
	libjava        : ChangeLog 
	libjava/testsuite/libjava.jacks: jacks.xfail 

Log message:
	* testsuite/libjava.jacks/jacks.xfail: Updated for PR java/23891.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3742&r2=1.3743
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.jacks/jacks.xfail.diff?cvsroot=gcc&r1=1.31&r2=1.32



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] [4.0 Regression] Problem folding static fields across packages

[mckinlay at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] [4.0 Regression] Problem folding static fields across packages

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-10-01 06:20 -------
Subject: Bug 23891

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	bryce@gcc.gnu.org	2005-10-01 06:20:39

Modified files:
	libjava        : ChangeLog 
	libjava/testsuite/libjava.jacks: jacks.xfail 
	gcc/java       : ChangeLog class.c java-tree.h jcf-parse.c 
	                 parse.y 

Log message:
	2005-10-01  Bryce McKinlay  <mckinlay@redhat.com>
	
	* testsuite/libjava.jacks/jacks.xfail: Update to reflect
	PR java/23891 fix.
	
	2005-10-01  Bryce McKinlay  <mckinlay@redhat.com>
	
	PR java/23891
	* parse.y (maybe_create_class_interface_decl): Set TYPE_PACKAGE for
	the newly created type. Set import lists here, not in create_class.
	(jdep_resolve_class): Set current_class.
	(do_resolve_class): Use current_class's TYPE_PACKAGE to determine
	the current package context, not ctxp->package.
	(cicp_cache): Removed.
	(class_in_current_package): Simplify implementation using
	TYPE_PACKAGE.
	* jcf-parse.c (give_name_to_class): Set TYPE_PACKAGE.
	* java-tree.h (TYPE_PACKAGE): New macro.
	(struct lang_type): New member 'package'.
	* class.c (maybe_layout_super_class): Update current_class before
	calling do_resolve_class.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.102&r2=1.3391.2.103
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.jacks/jacks.xfail.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.19.8.1&r2=1.19.8.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1556.2.32&r2=1.1556.2.33
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/class.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.220.8.5&r2=1.220.8.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/java-tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.226.8.2&r2=1.226.8.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/jcf-parse.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.183&r2=1.183.4.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.528.6.3&r2=1.528.6.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891

[Bug java/23891] [4.0 Regression] Problem folding static fields across packages

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-10-01 06:58 -------
Fixed on both HEAD and 4.0 branch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23891