[Bug libgcj/24552] New: Encoding alias "EUC_JP" missing

[Bug libgcj/24552] New: Encoding alias "EUC_JP" missing

[hnakamur at good-day dot co dot jp]

The member variable named "hash" in the gnu.gcj.convert.IOConverter class
should have a map entry key named "EUC_JP".

The encoding alias "EUC_JP" is on the list of the Sun's document:
  "Supported Encoding"
  http://java.sun.com/j2se/1.4.2/docs/guide/intl/encoding.doc.html
So GCJ should support this encoding alias.

We need the encoding alias "EUC_JP" when we run a java program which connects
to a PostgreSQL database whose encoding is EUC_JP through the PostgreSQL JDBC
driver.

If you look at IOConverter.java source flie,
http://savannah.gnu.org/cgi-bin/viewcvs/gcc/gcc/libjava/gnu/gcj/convert/IOConverter.java#rev1.8
the variable named "hash" has two duplicated "euc-jp" entries.
It must be a mistake that one of those should be "euc_jp", I think.

Here is a patch to fix this problem:

--- libjava/gnu/gcj/convert/IOConverter.java.orig       2005-10-27
12:19:32.739262400 +0900
+++ libjava/gnu/gcj/convert/IOConverter.java    2005-10-27 12:19:56.593563200
+0900
@@ -65,7 +65,7 @@
     hash.put ("extended_unix_code_packed_format_for_japanese", "EUCJIS");
     hash.put ("cseucpkdfmtjapanese", "EUCJIS");
     hash.put ("euc-jp", "EUCJIS");
-    hash.put ("euc-jp", "EUCJIS");
+    hash.put ("euc_jp", "EUCJIS");
     hash.put ("utf-16le", "UnicodeLittle");
     hash.put ("utf-16be", "UnicodeBig");
     iconv_byte_swap = iconv_init ();


-- 
           Summary: Encoding alias "EUC_JP" missing
           Product: gcc
           Version: 4.0.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hnakamur at good-day dot co dot jp


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24552

[Bug libgcj/24552] Encoding alias "EUC_JP" missing

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2005-10-27 13:59 -------
Related to PR14358


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24552

[Bug libgcj/24552] Encoding alias "EUC_JP" missing

[hnakamur at good-day dot co dot jp]

------- Comment #2 from hnakamur at good-day dot co dot jp  2005-10-31 02:03 -------
Yes, this is related to PR14358, but this is different from that.

Bug25552: EUC_JP
 PR14358: eucJP

We need both of aliases above. We also need the alias named "euc-jp".
So we need the three lines below.

hash.put ("euc-jp", "EUCJIS");
hash.put ("euc_jp", "EUCJIS");
hash.put ("eucjp", "EUCJIS");


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24552

[Bug libgcj/24552] Encoding alias "EUC_JP" missing

[tromey at gcc dot gnu dot org]

------- Comment #3 from tromey at gcc dot gnu dot org  2005-10-31 17:48 -------
I'll handle this.

I agree, we need this alias.
That particular part of the code is generated by
the script libjava/scripts/encodings.pl.

Looking at the current IANA character-sets file, I see
there is only this:

Alias: csEUCPkdFmtJapanese
Alias: EUC-JP  (preferred MIME name)

I think instead we should put a hand-maintained alias earlier
in the static initializer.

Unfortunately we can't do this until gcc trunk re-opens.
I'll put a patch on the 4.0 branch though.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-10-31 17:48:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24552

[Bug libgcj/24552] Encoding alias "EUC_JP" missing

[hnakamur at good-day dot co dot jp]

------- Comment #4 from hnakamur at good-day dot co dot jp  2005-11-01 01:48 -------
You are correct that IANA character-sets file only contains
two "EUC-JP" aliases: csEUCPkdFmtJapanese and EUC-JP.

But actually there are many non-Java programs which use other aliases and
do not accept above aliases.  Also I never see csEUCPkdFmtJapanese
anywhere else in the IANA character-sets.

I understand the situation that we can't put this patch to gcc trunk right
now and you will put it in the 4.0 branch.

Thank you for your help.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24552

[Bug libgcj/24552] Encoding alias "EUC_JP" missing

[tromey at gcc dot gnu dot org]

------- Comment #5 from tromey at gcc dot gnu dot org  2005-11-04 15:09 -------
Fix is on 4.0 branch and trunk.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24552