[Bug java/28090] New: incorrect implementation of expand_java_arraystore

[Bug java/28090] New: incorrect implementation of expand_java_arraystore

[tromey at gcc dot gnu dot org]

According to the ArrayStore.java test case, bounds checks should
take precedence over array store checks.  However, expand_java_arraystore
clearly does it in the wrong order:

  if (TREE_CODE (rhs_type_node) == POINTER_TYPE)
    {
      tree check = build_java_arraystore_check (array, rhs_node);
      java_add_stmt (check);
    }

  array = build_java_arrayaccess (array, rhs_type_node, index);


-- 
           Summary: incorrect implementation of expand_java_arraystore
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tromey at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-06-20 17:37 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2006-06-20 17:37:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[tromey at gcc dot gnu dot org]

------- Comment #2 from tromey at gcc dot gnu dot org  2006-06-20 17:42 -------
Created an attachment (id=11712)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11712&action=view)
proposed patch

I've attached a proposed patch.
However, when I use this patch I run into PR 19505.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[tromey at gcc dot gnu dot org]

-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-06-20 17:37:38         |2006-06-20 20:22:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[tromey at gcc dot gnu dot org]

------- Comment #3 from tromey at gcc dot gnu dot org  2006-07-18 15:12 -------
FWIW compiling from bytecode on svn head fails as well.
In fact the test case is xfailed in this case.
So this doesn't appear to be a regression.

Also I think this patch is bogus (but at least it shows the
right place to add the fix).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[bonzini at gnu dot org]

------- Comment #4 from bonzini at gnu dot org  2006-09-13 10:10 -------
PR19505 is fixed, is the patch still bad?


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bonzini at gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[aph at gcc dot gnu dot org]

------- Comment #5 from aph at gcc dot gnu dot org  2006-12-21 15:09 -------
I fixed PR19505 in July.  Should not this patch go in?

This is the last bug blocking 28067...


-- 

aph at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aph at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090

[Bug java/28090] incorrect implementation of expand_java_arraystore

[tromey at gcc dot gnu dot org]

------- Comment #6 from tromey at gcc dot gnu dot org  2007-01-09 20:37 -------
Andrew's fix for this went in with the merge.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090