[Bug java/31932] New: no values accepted for --encoding options except UTF-8

[Bug java/31932] New: no values accepted for --encoding options except UTF-8

[serg at vostok dot net]

Parts of gcc are compiled without libiconv even if it's present in the system
and --with-libiconv-prefix specified correctly.

The reason for this is usage of HAVE_ICONV_H macro.

1. The check for iconv.h in configure does not use the value of
--with-libiconv-prefix option.

2. HAVE_ICONV_H is useless because check for libiconv uses iconv.h anyway.

3. HAVE_ICONV is changed in some source files like this:

#ifndef HAVE_ICONV_H
#undef HAVE_ICONV
#endif

- which is inherently incorrect in and of itself: any information produced by
configure must not be changed in the source code. If configure tests don't work
right - fix them, but all source code must be compiled with the same global
settings.


-- 
           Summary: no values accepted for --encoding options except UTF-8
           Product: gcc
           Version: 4.1.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: serg at vostok dot net
 GCC build triplet: i386-portbld-freebsd6.2
  GCC host triplet: i386-portbld-freebsd6.2
GCC target triplet: i386-portbld-freebsd6.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug java/31932] no values accepted for --encoding options except UTF-8

[serg at vostok dot net]

------- Comment #1 from serg at vostok dot net  2007-05-15 11:25 -------
Created an attachment (id=13557)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13557&action=view)
Removes HAVE_ICONV_H from source code.

This should fix the bug. And, probably, some other problems with gcc not using
iconv.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug java/31932] no values accepted for --encoding options except UTF-8

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2007-05-15 15:33 -------
This code has been removed in 4.3.0 anyways as the java source parser is gone. 
Only the bytecode parser exists on the trunk.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug libstdc++/31932] no values accepted for --encoding options except UTF-8

[serg at vostok dot net]

------- Comment #3 from serg at vostok dot net  2007-05-15 17:29 -------
(In reply to comment #2)
> This code has been removed in 4.3.0 anyways as the java source parser is gone. 
> Only the bytecode parser exists on the trunk.

That still means 4.1 and 4.2 branches can be fixed.

Also not only java source parser is affected: libcpp/internal.h has this bug
too. I just don't know how to expose it there.

Which component should I tag as buggy? libstdc++?


-- 

serg at vostok dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |serg at vostok dot net
          Component|java                        |libstdc++


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug java/31932] no values accepted for --encoding options except UTF-8

[pcarlini at suse dot de]

------- Comment #4 from pcarlini at suse dot de  2007-05-15 19:30 -------
I don't think libstdc++ (the C++ runtime library) has anything to do with this.


-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libstdc++                   |java


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug java/31932] no values accepted for --encoding options except UTF-8

[tromey at gcc dot gnu dot org]

------- Comment #5 from tromey at gcc dot gnu dot org  2007-05-15 19:41 -------
The patch is incomplete, as libcpp/configure.in still checks for iconv.h.

Anyway the best thing to do here is submit a patch or patches to the
gcc patch list.  Include a ChangeLog entry, etc.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] no values accepted for --encoding options except UTF-8

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2007-05-15 19:43 -------
libcpp is the C PreProcessor (not the standard C++ library).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|java                        |preprocessor


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] no values accepted for --encoding options except UTF-8

[serg at vostok dot net]

------- Comment #7 from serg at vostok dot net  2007-05-15 20:08 -------
Created an attachment (id=13562)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13562&action=view)
Removes HAVE_ICONV_H from source code.

Added libcpp/configure and libcpp/configure.ac to the patch.


-- 

serg at vostok dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13557|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] cpp -f*-charset and gcj --encoding accept no values except UTF-8

[serg at vostok dot net]

------- Comment #8 from serg at vostok dot net  2007-05-15 20:34 -------
(In reply to comment #6)
> libcpp is the C PreProcessor (not the standard C++ library).

Thanks. Now I know how to expose the bug here as well. It's -f*-charset options
of cpp.


-- 

serg at vostok dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|no values accepted for --   |cpp -f*-charset and gcj --
                   |encoding options except UTF-|encoding accept no values
                   |8                           |except UTF-8


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] cpp -f*-charset and gcj --encoding accept no values except UTF-8

[jsm28 at gcc dot gnu dot org]

-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-03-29 23:48:10
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] cpp -f*-charset and gcj --encoding accept no values except UTF-8

[tromey at gcc dot gnu dot org]

------- Comment #9 from tromey at gcc dot gnu dot org  2009-03-30 20:54 -------
Subject: Bug 31932

Author: tromey
Date: Mon Mar 30 20:54:18 2009
New Revision: 145316

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=145316
Log:
2009-03-30  Sergiy Vyshnevetskiy  <serg@vostok.net>

        PR preprocessor/31932:
        * internal.h: Don't mention HAVE_ICONV_H.
        * configure, config.in: Rebuild.
        * configure.ac: Don't check for iconv.h.

Modified:
    trunk/libcpp/ChangeLog
    trunk/libcpp/config.in
    trunk/libcpp/configure
    trunk/libcpp/configure.ac
    trunk/libcpp/internal.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] cpp -f*-charset and gcj --encoding accept no values except UTF-8

[tromey at gcc dot gnu dot org]

------- Comment #11 from tromey at gcc dot gnu dot org  2009-03-30 20:57 -------
Oops, updated wrong field.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|4.5.0                       |
      Known to work|                            |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] cpp -f*-charset and gcj --encoding accept no values except UTF-8

[tromey at gcc dot gnu dot org]

------- Comment #10 from tromey at gcc dot gnu dot org  2009-03-30 20:57 -------
I checked in the fix on the trunk.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932

[Bug preprocessor/31932] cpp -f*-charset and gcj --encoding accept no values except UTF-8

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2009-04-16 19:05 -------
Fixed so closing.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31932