public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgcj/13288] MulticastSocket not joining more than one interface
       [not found] <bug-13288-6895@http.gcc.gnu.org/bugzilla/>
@ 2007-10-29 20:43 ` BenGardiner at nanometrics dot ca
  2007-11-05 18:43 ` tromey at gcc dot gnu dot org
  1 sibling, 0 replies; 2+ messages in thread
From: BenGardiner at nanometrics dot ca @ 2007-10-29 20:43 UTC (permalink / raw)
  To: java-prs



------- Comment #2 from BenGardiner at nanometrics dot ca  2007-10-29 20:43 -------
Created an attachment (id=14436)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14436&action=view)
a patch for libjava/gnu/java/net/natPlainDatagramSocketImplPosix.cc to use the
given NetworkInterface* in the IP_ADD_MEMBERSHIP sockopt call. 

Created for gcc 4.0.1's libjava; noticed that the file in trunk still has the
FIXME. 

The change affects how multicast join/leave is implemented: if the
NetworkInterface* passed in the arguments is null, then the behaviour is the
same as the previous. That is, put the INADDR_ANY value into the ip_mreq
structure and pass it to the kernel (on linux 2.4.24 this ends up always
referring to the default gateway interface); otherwise, create a ip_mreq
structure for each address owned by the NetworkInterface and pass it to the
kernel. 

For linux it is a little overkill to do an IP_ADD_MEMBERSHIP call for each
address owned by the network interface, since they will each get mapped back
into the interface inside the kernel. It seemed that since the ip_mreq (mostly
standard) structure contained no field for a specific interface, the mostly
standard thing to do would be to do an _ADD_ for each address. If this is not
needed to accomodate all unices (something Im not qualified to decide) the
method could always do what is done in the openJDK: do an _ADD_ for the first
interface address owned by the NetworkInterface.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13288


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug libgcj/13288] MulticastSocket not joining more than one interface
       [not found] <bug-13288-6895@http.gcc.gnu.org/bugzilla/>
  2007-10-29 20:43 ` [Bug libgcj/13288] MulticastSocket not joining more than one interface BenGardiner at nanometrics dot ca
@ 2007-11-05 18:43 ` tromey at gcc dot gnu dot org
  1 sibling, 0 replies; 2+ messages in thread
From: tromey at gcc dot gnu dot org @ 2007-11-05 18:43 UTC (permalink / raw)
  To: java-prs



------- Comment #3 from tromey at gcc dot gnu dot org  2007-11-05 18:43 -------
For a patch of this size, we'll need an assignment.
Please contact me via email and I will get you started on this.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13288


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-05 18:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-13288-6895@http.gcc.gnu.org/bugzilla/>
2007-10-29 20:43 ` [Bug libgcj/13288] MulticastSocket not joining more than one interface BenGardiner at nanometrics dot ca
2007-11-05 18:43 ` tromey at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).