* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
@ 2006-03-15 17:17 ` tromey at gcc dot gnu dot org
2008-08-22 16:18 ` aph at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tromey at gcc dot gnu dot org @ 2006-03-15 17:17 UTC (permalink / raw)
To: java-prs
------- Comment #3 from tromey at gcc dot gnu dot org 2006-03-15 17:17 -------
Despite what the original report says, we don't really want to
resolve all entries when compiling.
Also it would be best to avoid any kind of synchronization at all.
One idea would be to 'or' the argument to one of these instructions
with 0x1 when the datum is unresolved. This can be tested reasonably
quickly. And, since these lookups are all idempotent, it does not
matter if two threads happen to do a small amount of redudant lookup
work.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
2006-03-15 17:17 ` [Bug libgcj/8995] race cases in interpreter tromey at gcc dot gnu dot org
@ 2008-08-22 16:18 ` aph at gcc dot gnu dot org
2008-08-22 16:20 ` aph at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: aph at gcc dot gnu dot org @ 2008-08-22 16:18 UTC (permalink / raw)
To: java-prs
------- Comment #4 from aph at gcc dot gnu dot org 2008-08-22 16:18 -------
Subject: Bug 8995
Author: aph
Date: Fri Aug 22 16:17:19 2008
New Revision: 139493
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139493
Log:
Fix PR#.
2008-08-22 Andrew Haley <aph@redhat.com>
PR libgcj/8995:
* interpret-run.cc (REWRITE_INSN): Null this macro.
* include/jvm.h (class _Jv_Linker): Declare resolve_mutex, init.
(read_cpool_entry, write_cpool_entry): New functions.
* link.cc (_Jv_Linker::resolve_mutex): new.
(_Jv_Linker::init): New function.
(_Jv_Linker::resolve_pool_entry): Use {read,write}_cpool_entry
to ensure atomic access to constant pool entries.
Modified:
trunk/libjava/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
2006-03-15 17:17 ` [Bug libgcj/8995] race cases in interpreter tromey at gcc dot gnu dot org
2008-08-22 16:18 ` aph at gcc dot gnu dot org
@ 2008-08-22 16:20 ` aph at gcc dot gnu dot org
2008-08-22 16:58 ` aph at gcc dot gnu dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: aph at gcc dot gnu dot org @ 2008-08-22 16:20 UTC (permalink / raw)
To: java-prs
------- Comment #5 from aph at gcc dot gnu dot org 2008-08-22 16:20 -------
Subject: Bug 8995
Author: aph
Date: Fri Aug 22 16:04:29 2008
New Revision: 139492
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139492
Log:
2008-08-22 Andrew Haley <aph@redhat.com>
PR libgcj/8895:
* interpret-run.cc (REWRITE_INSN): Null this macro.
* include/jvm.h (class _Jv_Linker): Declare resolve_mutex, init.
(read_cpool_entry, write_cpool_entry): New functions.
* link.cc (_Jv_Linker::resolve_mutex): new.
(_Jv_Linker::init): New function.
(_Jv_Linker::resolve_pool_entry): Use {read,write}_cpool_entry
to ensure atomic access to constant pool entries.
Modified:
trunk/libjava/ChangeLog
trunk/libjava/include/jvm.h
trunk/libjava/interpret-run.cc
trunk/libjava/link.cc
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2008-08-22 16:20 ` aph at gcc dot gnu dot org
@ 2008-08-22 16:58 ` aph at gcc dot gnu dot org
2008-09-23 13:52 ` aph at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: aph at gcc dot gnu dot org @ 2008-08-22 16:58 UTC (permalink / raw)
To: java-prs
------- Comment #6 from aph at gcc dot gnu dot org 2008-08-22 16:58 -------
Subject: Bug 8995
Author: aph
Date: Fri Aug 22 16:57:11 2008
New Revision: 139494
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139494
Log:
2008-08-22 Andrew Haley <aph@redhat.com>
PR libgcj/8995:
* interpret-run.cc (REWRITE_INSN): Null this macro.
* include/jvm.h (class _Jv_Linker): Declare resolve_mutex, init.
(read_cpool_entry, write_cpool_entry): New functions.
* link.cc (_Jv_Linker::resolve_mutex): new.
(_Jv_Linker::init): New function.
(_Jv_Linker::resolve_pool_entry): Use {read,write}_cpool_entry
to ensure atomic access to constant pool entries.
Modified:
branches/gcc-4_3-branch/libjava/ChangeLog
branches/gcc-4_3-branch/libjava/include/jvm.h
branches/gcc-4_3-branch/libjava/interpret-run.cc
branches/gcc-4_3-branch/libjava/link.cc
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2008-08-22 16:58 ` aph at gcc dot gnu dot org
@ 2008-09-23 13:52 ` aph at gcc dot gnu dot org
2008-12-27 14:45 ` pinskia at gcc dot gnu dot org
2009-02-05 9:42 ` aph at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: aph at gcc dot gnu dot org @ 2008-09-23 13:52 UTC (permalink / raw)
To: java-prs
------- Comment #7 from aph at gcc dot gnu dot org 2008-09-23 13:52 -------
Subject: Bug 8995
Author: aph
Date: Tue Sep 23 13:51:58 2008
New Revision: 140593
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140593
Log:
2008-09-17 Andrew Haley <aph@redhat.com>
PR libgcj/8995:
* defineclass.cc (_Jv_ClassReader::handleCodeAttribute):
Initialize thread_count.
* include/java-interp.h (_Jv_InterpMethod::thread_count): New
field.
(_Jv_InterpMethod::rewrite_insn_mutex): New mutex.
(_Jv_InterpFrame:: _Jv_InterpFrame): Pass frame_type.
* interpret.cc
(ThreadCountAdjuster): New class.
(_Jv_InterpMethod::thread_count): New field.
(_Jv_InitInterpreter): Initialize rewrite_insn_mutex.
Increment and decrement thread_count field in methods.
* interpret-run.cc (REWRITE_INSN): Check thread_count <= 1.
(REWRITE_INSN): Likewise.
Declare a ThreadCountAdjuster.
* java/lang/reflect/natVMProxy.cc (run_proxy): Initialize frame
type as frame_proxy.
Modified:
trunk/libjava/ChangeLog
trunk/libjava/defineclass.cc
trunk/libjava/include/java-interp.h
trunk/libjava/interpret-run.cc
trunk/libjava/interpret.cc
trunk/libjava/java/lang/reflect/natVMProxy.cc
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2008-09-23 13:52 ` aph at gcc dot gnu dot org
@ 2008-12-27 14:45 ` pinskia at gcc dot gnu dot org
2009-02-05 9:42 ` aph at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-12-27 14:45 UTC (permalink / raw)
To: java-prs
------- Comment #8 from pinskia at gcc dot gnu dot org 2008-12-27 14:45 -------
*** Bug 37051 has been marked as a duplicate of this bug. ***
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chewi at aura-online dot co
| |dot uk
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libgcj/8995] race cases in interpreter
[not found] <bug-8995-360@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2008-12-27 14:45 ` pinskia at gcc dot gnu dot org
@ 2009-02-05 9:42 ` aph at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: aph at gcc dot gnu dot org @ 2009-02-05 9:42 UTC (permalink / raw)
To: java-prs
------- Comment #9 from aph at gcc dot gnu dot org 2009-02-05 09:42 -------
.
--
aph at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=8995
^ permalink raw reply [flat|nested] 8+ messages in thread