public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgcj/38872]  New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols
@ 2009-01-16 14:23 jakub at gcc dot gnu dot org
  2009-01-16 14:59 ` [Bug libgcj/38872] " aph at gcc dot gnu dot org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-01-16 14:23 UTC (permalink / raw)
  To: java-prs

While comparing list of exported symbols, libgcj_bc.so.1 hasn't dropped any
symbols from 4.3 (correct, hasn't changed SONAME), but libgcj.so.10 dropped
_Jv_CreateJavaVM and _Jv_GetStringChars symbols compared to libgcj.so.9.
That wouldn't normally be an issue (they have different SONAME), but in this
case, as they are listed in libgcj_bc.so and thus part of libgcj_bc.so.1
ABI, this is an ABI break.  Seems _Jv_CreateJavaVM is still exported from
libgcj.so.10, but unlike 4.3 as extern "C++" name (mangled,
_Z16_Jv_CreateJavaVMP14_Jv_VMInitArgs), while previously
it was exported as extern "C".  _Jv_GetStringChars isn't exported at all.

Seen at least on x86_64-linux and i686-linux.

Can this be fixed before 4.4 release?


-- 
           Summary: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and
                    _Jv_GetStringChars symbols
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38872


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgcj/38872] [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols
  2009-01-16 14:23 [Bug libgcj/38872] New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols jakub at gcc dot gnu dot org
@ 2009-01-16 14:59 ` aph at gcc dot gnu dot org
  2009-01-16 16:04 ` rguenth at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: aph at gcc dot gnu dot org @ 2009-01-16 14:59 UTC (permalink / raw)
  To: java-prs



------- Comment #1 from aph at gcc dot gnu dot org  2009-01-16 14:59 -------
Thanks for looking.

As far as I can see _Jv_GetStringChars has been extern inline forever, so
doesn't matter.  Probably should have a matching definition, but will never be
called.

_Jv_CreateJavaVM in libgcj.so.9 is:

00000032e57a5690 T _Z16_Jv_CreateJavaVMP14_Jv_VMInitArgs

in libgcj.so.7 is:

0000000001071e30 T _Z16_Jv_CreateJavaVMP14_Jv_VMInitArgs

This change was made in 2005.  It seems to have been a mistake, but no-one
noticed.  The only way to fix it will be to add an alias.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38872


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgcj/38872] [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols
  2009-01-16 14:23 [Bug libgcj/38872] New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols jakub at gcc dot gnu dot org
  2009-01-16 14:59 ` [Bug libgcj/38872] " aph at gcc dot gnu dot org
@ 2009-01-16 16:04 ` rguenth at gcc dot gnu dot org
  2009-01-17  8:00 ` jakub at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2009-01-16 16:04 UTC (permalink / raw)
  To: java-prs



-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ABI
           Priority|P3                          |P1
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38872


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgcj/38872] [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols
  2009-01-16 14:23 [Bug libgcj/38872] New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols jakub at gcc dot gnu dot org
  2009-01-16 14:59 ` [Bug libgcj/38872] " aph at gcc dot gnu dot org
  2009-01-16 16:04 ` rguenth at gcc dot gnu dot org
@ 2009-01-17  8:00 ` jakub at gcc dot gnu dot org
  2009-01-27 10:09 ` jakub at gcc dot gnu dot org
  2009-01-27 10:18 ` jakub at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-01-17  8:00 UTC (permalink / raw)
  To: java-prs



------- Comment #2 from jakub at gcc dot gnu dot org  2009-01-17 08:00 -------
Then _Jv_GetStringChars should be dropped from libgcj_bc.so too.
And for the other function, I think adding a "C" alias in libgcj.so.* and
a C++ in libgcj_bc.so wouldn't hurt.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38872


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgcj/38872] [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols
  2009-01-16 14:23 [Bug libgcj/38872] New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols jakub at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2009-01-17  8:00 ` jakub at gcc dot gnu dot org
@ 2009-01-27 10:09 ` jakub at gcc dot gnu dot org
  2009-01-27 10:18 ` jakub at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-01-27 10:09 UTC (permalink / raw)
  To: java-prs



------- Comment #3 from jakub at gcc dot gnu dot org  2009-01-27 10:09 -------
Subject: Bug 38872

Author: jakub
Date: Tue Jan 27 10:09:23 2009
New Revision: 143698

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143698
Log:
        PR libgcj/38872
        * gcj/javaprims.h (_Jv_CreateJavaVM): Change to extern "C" symbol.
        * libjgc_bc.c (_Jv_GetStringChars): Remove.

Modified:
    trunk/libjava/ChangeLog
    trunk/libjava/gcj/javaprims.h
    trunk/libjava/libgcj_bc.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38872


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgcj/38872] [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols
  2009-01-16 14:23 [Bug libgcj/38872] New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols jakub at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2009-01-27 10:09 ` jakub at gcc dot gnu dot org
@ 2009-01-27 10:18 ` jakub at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-01-27 10:18 UTC (permalink / raw)
  To: java-prs



------- Comment #4 from jakub at gcc dot gnu dot org  2009-01-27 10:18 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38872


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-01-27 10:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-16 14:23 [Bug libgcj/38872] New: [4.4 Regression] libgcj.so dropped _Jv_CreateJavaVM and _Jv_GetStringChars symbols jakub at gcc dot gnu dot org
2009-01-16 14:59 ` [Bug libgcj/38872] " aph at gcc dot gnu dot org
2009-01-16 16:04 ` rguenth at gcc dot gnu dot org
2009-01-17  8:00 ` jakub at gcc dot gnu dot org
2009-01-27 10:09 ` jakub at gcc dot gnu dot org
2009-01-27 10:18 ` jakub at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).