[Bug libgcj/24834] New: PersistentByteMap close() method is not catching Exception

[Bug libgcj/24834] New: PersistentByteMap close() method is not catching Exception

[m4341 at abc dot se]

the close() method from java.nio.channels.FileChannel (through
java.nio.channels.spi.AbstractInterruptibleChannel) is throwing an exception
inside the close() method in gnu.gcj.runtime.PersistentByteMap.

This can be resolved in two ways:
1. Catch the Exception in the close() method and just drop the Exception.
(since it's a close that fails it shouldn't cause too much trouble).
2. Let the close() method throw it further up in the hirearchy. (formally
right, but is it needed?)


-- 
           Summary: PersistentByteMap close() method is not catching
                    Exception
           Product: gcc
           Version: 4.0.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: m4341 at abc dot se


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24834

[Bug libgcj/24834] PersistentByteMap close() method is not catching Exception

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2005-11-14 13:18 -------
Do you have a testcase for this one?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24834

[Bug libgcj/24834] PersistentByteMap close() method is not catching Exception

[m4341 at abc dot se]

------- Comment #2 from m4341 at abc dot se  2005-11-14 18:42 -------
This was detected by opening the whole set of Java files in Eclipse (and not
having any standard Java library at all selected). The close method stood out
as an error. since it was declared to throw an exception in the classes
AbstractInterruptibleChannel and FileChannel, but when used in
PersistentByteMap it was not caught.

I did this as an effort to try to strip out the parts I didn't need like AWT
and then I encountered this.

I hope that this is sufficient as an explanation to the bug. It doesn't seem to
be critical.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24834

[Bug libgcj/24834] PersistentByteMap close() method is not catching Exception

[tromey at gcc dot gnu dot org]

------- Comment #3 from tromey at gcc dot gnu dot org  2006-03-08 00:37 -------
I looked and as far as I can see, this bug is fixed in 4.1.
PersistentByteMap.close now throws IOException.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24834