[Bug libgcj/28546] New: ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[Bug libgcj/28546] New: ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[danglin at gcc dot gnu dot org]

/xxx/gnu/gcc/objdir/./gcc/xgcc -shared-libgcc -B/xxx/gnu/gcc/objdir/./gcc
-nostd
inc++ -L/xxx/gnu/gcc/objdir/hppa2.0w-hp-hpux11.00/libstdc++-v3/src
-L/xxx/gnu/gc
c/objdir/hppa2.0w-hp-hpux11.00/libstdc++-v3/src/.libs
-B/opt/gnu/gcc/gcc-4.2.0/h
ppa2.0w-hp-hpux11.00/bin/ -B/opt/gnu/gcc/gcc-4.2.0/hppa2.0w-hp-hpux11.00/lib/
-i
system /opt/gnu/gcc/gcc-4.2.0/hppa2.0w-hp-hpux11.00/include -isystem
/opt/gnu/gc
c/gcc-4.2.0/hppa2.0w-hp-hpux11.00/sys-include -DHAVE_CONFIG_H -I.
-I../../../gcc
/libjava -I./include -I./gcj -I../../../gcc/libjava -Iinclude
-I../../../gcc/lib
java/include -I../../../gcc/libjava/classpath/include -Iclasspath/include
-I../.
./../gcc/libjava/classpath/native/fdlibm
-I../../../gcc/libjava/../boehm-gc/incl
ude -I../boehm-gc/include -I../../../gcc/libjava/libltdl
-I../../../gcc/libjava/
libltdl -I../../../gcc/libjava/.././libjava/../gcc
-I../../../gcc/libjava/../zli
b -I../../../gcc/libjava/../libffi/include -I../libffi/include -fno-rtti
-fnon-c
all-exceptions -fdollars-in-identifiers -Wswitch-enum -D_FILE_OFFSET_BITS=64
-We
xtra -Wall -D_GNU_SOURCE -DPREFIX=\"/opt/gnu/gcc/gcc-4.2.0\"
-DLIBDIR=\"/opt/gnu
/gcc/gcc-4.2.0/lib\" -DJAVA_HOME=\"/opt/gnu/gcc/gcc-4.2.0\"
-DBOOT_CLASS_PATH=\"
/opt/gnu/gcc/gcc-4.2.0/share/java/libgcj-4.2.0.jar\"
-DJAVA_EXT_DIRS=\"/opt/gnu/
gcc/gcc-4.2.0/share/java/ext\"
-DGCJ_ENDORSED_DIRS=\"/opt/gnu/gcc/gcc-4.2.0/shar
e/java/gcj-endorsed\"
-DGCJ_VERSIONED_LIBDIR=\"/opt/gnu/gcc/gcc-4.2.0/lib/gcj-4.
2.0\" -DPATH_SEPARATOR=\":\"
-DLIBGCJ_DEFAULT_DATABASE=\"/opt/gnu/gcc/gcc-4.2.0/
lib/gcj-4.2.0/classmap.db\"
-DLIBGCJ_DEFAULT_DATABASE_PATH_TAIL=\"gcj-4.2.0/clas
smap.db\" -DTOOLEXECLIBDIR=\"/opt/gnu/gcc/gcc-4.2.0/lib\" -g -O2 -MT prims.lo
-M
D -MP -MF .deps/prims.Tpo -c ../../../gcc/libjava/prims.cc  -fPIC -DPIC -o
.libs
/prims.o
./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'
./include/java-threads.h:28: error: '_Jv_Thread_t' has a previous declaration
he
re
make[3]: *** [prims.lo] Error 1

Thread.h:

...
class _Jv_JNIEnv;
class _Jv_Thread_t;
#define _JV_NOT_OWNER 1
...

java-threads.h:

...
typedef int _Jv_Mutex_t;
typedef int _Jv_Thread_t;
typedef void _Jv_ThreadStartFunc (java::lang::Thread *);
...


-- 
           Summary: ./java/lang/Thread.h:31: error: using typedef-name
                    '_Jv_Thread_t' after 'class'
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.00
  GCC host triplet: hppa2.0w-hp-hpux11.00
GCC target triplet: hppa2.0w-hp-hpux11.00


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|./java/lang/Thread.h:31:    |[4.2 Regression]
                   |error: using typedef-name   |./java/lang/Thread.h:31:
                   |'_Jv_Thread_t' after 'class'|error: using typedef-name
                   |                            |'_Jv_Thread_t' after 'class'
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[andreast at gcc dot gnu dot org]

------- Comment #1 from andreast at gcc dot gnu dot org  2006-07-30 20:21 -------
This is in include/no-threads.h.

So, we either have a posix-thread detection issue on hppa2.0w-hp-hpux11.00 or
posix threads are not supported here.

Just for the record, hppa2.0w-hp-hpux11.11 does work.

If the first is the case, we have to investigate why.
If the second is the case, we have to adapt include/no-threads.h to match the
compilation.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #2 from dave at hiauly1 dot hia dot nrc dot ca  2006-07-30 20:51 -------
Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31: error: using
typedef-name '_Jv_Thread_t' after 'class'

> This is in include/no-threads.h.

Ah, that's correct since I see I specified '--enable-threads=single'.
I was going to work further on the _REENTRANT problem but lost track
of this fact.

In any event, we didn't used to hit this problem.  The forward
declaration in Makefile.am seems like a hack.

> So, we either have a posix-thread detection issue on hppa2.0w-hp-hpux11.00 or
> posix threads are not supported here.
> 
> Just for the record, hppa2.0w-hp-hpux11.11 does work.

Probably not if configured with '--enable-threads=single'.  This is
the default on hpux11.  POSIX threads are always available, so possibly
we should just force posix threads.  On the otherhand, I'm still
thinking that I would like '--enable-threads=single' to work for hpux10.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[toa at pop dot agri dot ch]

------- Comment #3 from toa at pop dot agri dot ch  2006-07-30 21:06 -------
Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31:
 error: using typedef-name '_Jv_Thread_t' after 'class'

dave at hiauly1 dot hia dot nrc dot ca wrote:
> ------- Comment #2 from dave at hiauly1 dot hia dot nrc dot ca  2006-07-30 20:51 -------
> Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31: error: using
> typedef-name '_Jv_Thread_t' after 'class'
> 
>> This is in include/no-threads.h.
> 
> Ah, that's correct since I see I specified '--enable-threads=single'.
> I was going to work further on the _REENTRANT problem but lost track
> of this fact.
> 
> In any event, we didn't used to hit this problem.  The forward
> declaration in Makefile.am seems like a hack.
> 
>> So, we either have a posix-thread detection issue on hppa2.0w-hp-hpux11.00 or
>> posix threads are not supported here.
>>
>> Just for the record, hppa2.0w-hp-hpux11.11 does work.
> 
> Probably not if configured with '--enable-threads=single'.  This is
> the default on hpux11.  POSIX threads are always available, so possibly
> we should just force posix threads.  On the otherhand, I'm still
> thinking that I would like '--enable-threads=single' to work for hpux10.

Right and right, and I think it is platform independent. If one uses 
--enable-threads=single on any platform we will hit this compilation 
problem.

So, the right way to solve this is to attack the include/no-threads.h place.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[tromey at gcc dot gnu dot org]

------- Comment #4 from tromey at gcc dot gnu dot org  2006-07-31 21:14 -------
The forward declaration is kind of a hack.  I'm not sure why it is needed.

In any case, no-threads is also a big hack.
It wouldn't hurt to simply change the _Jv_Thread_t there to a class.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-07-31 21:14:56
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[andreast at gcc dot gnu dot org]

------- Comment #5 from andreast at gcc dot gnu dot org  2006-07-31 22:15 -------
Working on a patch.


-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |andreast at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-07-31 21:14:56         |2006-07-31 22:15:47
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #6 from dave at hiauly1 dot hia dot nrc dot ca  2006-07-31 22:23 -------
Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31: error: using
typedef-name '_Jv_Thread_t' after 'class'

> ------- Comment #5 from andreast at gcc dot gnu dot org  2006-07-31 22:15 -------
> Working on a patch.

Trying the patch below.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

Index: include/no-threads.h
===================================================================
--- include/no-threads.h        (revision 115793)
+++ include/no-threads.h        (working copy)
@@ -25,7 +25,10 @@

 typedef int _Jv_ConditionVariable_t;
 typedef int _Jv_Mutex_t;
-typedef int _Jv_Thread_t;
+typedef struct _Jv_Thread_t
+{
+  int thread;
+};
 typedef void _Jv_ThreadStartFunc (java::lang::Thread *);




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[mmitchel at gcc dot gnu dot org]

------- Comment #7 from mmitchel at gcc dot gnu dot org  2006-07-31 23:42 -------
Java is not release-critical.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #8 from dave at hiauly1 dot hia dot nrc dot ca  2006-08-01 00:16 -------
Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31: error: using
typedef-name '_Jv_Thread_t' after 'class'

> ------- Comment #7 from mmitchel at gcc dot gnu dot org  2006-07-31 23:42 -------
> Java is not release-critical.

Just thinking, wouldn't it save a bit of work if each component had
its own default priority?

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[andreast at gcc dot gnu dot org]

------- Comment #9 from andreast at gcc dot gnu dot org  2006-08-01 20:24 -------
Patch is here:

http://gcc.gnu.org/ml/java-patches/2006-q3/msg00249.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[andreast at gcc dot gnu dot org]

------- Comment #11 from andreast at gcc dot gnu dot org  2006-08-02 20:18 -------
Fixed.


-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[andreast at gcc dot gnu dot org]

------- Comment #10 from andreast at gcc dot gnu dot org  2006-08-02 20:18 -------
Subject: Bug 28546

Author: andreast
Date: Wed Aug  2 20:18:05 2006
New Revision: 115883

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115883
Log:
2006-08-02  Andreas Tobler  <a.tobler@schweiz.ch>

        PR libgcj/28546
        * include/no-threads.h: Declare _Jv_Thread_t as empty class.

Modified:
    trunk/libjava/ChangeLog
    trunk/libjava/include/no-threads.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #12 from dave at hiauly1 dot hia dot nrc dot ca  2006-08-02 20:26 -------
Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31: error: using
typedef-name '_Jv_Thread_t' after 'class'

> ------- Comment #11 from andreast at gcc dot gnu dot org  2006-08-02 20:18 -------
> Fixed.

Thanks.  Next problem is stack traces with no threads.

Exception in thread "main" java.lang.InternalError: Thread.start called but thr
eads not available
*** Got java.lang.InternalError: Thread.start called but threads not available
while trying to print stack trace.
FAIL: PR18699 execution - source compiled test

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[andreast at gcc dot gnu dot org]

------- Comment #13 from andreast at gcc dot gnu dot org  2006-08-04 22:22 -------
The only thing I can do is trying to make the failing test cases
conditionalized.
I'm not a wizzard to make a non threading system having threads :)

Andreas


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546

[Bug libgcj/28546] [4.2 Regression] ./java/lang/Thread.h:31: error: using typedef-name '_Jv_Thread_t' after 'class'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #14 from dave at hiauly1 dot hia dot nrc dot ca  2006-08-04 22:29 -------
Subject: Re:  [4.2 Regression] ./java/lang/Thread.h:31: error: using
typedef-name '_Jv_Thread_t' after 'class'

> The only thing I can do is trying to make the failing test cases
> conditionalized.

That would be fine.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28546