[Bug java/52730] Java front end emits assembly

[Bug java/52730] Java front end emits assembly

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|bootstrap                   |java
            Version|4.7.0                       |4.8.0
            Summary|[4.8 Regression] bootstrap  |Java front end emits
                   |failure on Linux/ia32       |assembly

--- Comment #2 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-26 20:18:49 UTC ---
I believe the following should fix the problem, altough I fail to see how this
can ever have worked with LTO.  HJ, could you test this for me, please? I have
no access to ia32 anymore. 

Index: class.c
===================================================================
--- class.c     (revision 185813)
+++ class.c     (working copy)
@@ -3241,6 +3241,7 @@ java_write_globals (void)
   write_global_declarations ();
   emit_debug_global_declarations (vec, len);
   VEC_free (tree, gc, pending_static_fields);
+  java_emit_static_constructor ();
 }

 #include "gt-java-class.h"
Index: jcf-parse.c
===================================================================
--- jcf-parse.c (revision 185813)
+++ jcf-parse.c (working copy)
@@ -1689,7 +1689,7 @@ predefined_filename_p (tree node)
 /* Generate a function that does all static initialization for this 
    translation unit.  */

-static void
+void
 java_emit_static_constructor (void)
 {
   tree body = NULL;
@@ -1974,8 +1974,6 @@ java_parse_file (void)
   bitmap_obstack_release (&bit_obstack);

  finish:
-  /* Arrange for any necessary initialization to happen.  */
-  java_emit_static_constructor ();
   gcc_assert (global_bindings_p ());
 }

Index: java-tree.h
===================================================================
--- java-tree.h (revision 185813)
+++ java-tree.h (working copy)
@@ -940,6 +940,7 @@ struct GTY((variable_size)) lang_type {
 struct eh_range;

 extern void java_parse_file (void);
+extern void java_emit_static_constructor (void);
 extern tree java_type_for_mode (enum machine_mode, int);
 extern tree java_type_for_size (unsigned int, int);
 extern tree java_truthvalue_conversion (tree);

[Bug java/52730] Java front end emits assembly

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-03-26 20:53:34 UTC ---
> I believe the following should fix the problem, altough I fail to see how this
> can ever have worked with LTO. 

Java doesn't work with LTO.

[Bug java/52730] Java front end emits assembly

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> 2012-03-26 21:09:17 UTC ---
(In reply to comment #2)
> I believe the following should fix the problem, altough I fail to see how this
> can ever have worked with LTO.  HJ, could you test this for me, please? I have
> no access to ia32 anymore. 

It also failed on Linux/x86-64:

http://gcc.gnu.org/ml/gcc-regression/2012-03/msg00268.html

when configured with

--prefix=/usr/local --enable-clocale=gnu --with-system-zlib --enable-shared
--with-demangler-in-ld --with-fpmath=sse
--enable-languages=c,c++,fortran,java,lto,objc

[Bug java/52730] Java front end emits assembly

[stevenb.gcc at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

--- Comment #5 from stevenb.gcc at gmail dot com <stevenb.gcc at gmail dot com> 2012-03-26 21:31:44 UTC ---
Yes, I've reverted that patch for the time being.

[Bug java/52730] Java front end emits assembly

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu.org

--- Comment #7 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-27 20:12:21 UTC ---
Java maintainer help needed.

[Bug java/52730] Java front end emits assembly

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

--- Comment #8 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-29 21:00:32 UTC ---
Author: steven
Date: Thu Mar 29 21:00:23 2012
New Revision: 185977

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185977
Log:
    PR java/52730
    * class.c (emit_register_classes_in_jcr_section): New function.
    (emit_Jv_RegisterClass_calls): New function, split out from ...
    (emit_register_classes): ... here. Reorganize.  Do not call
    output_constant.


Modified:
    trunk/gcc/java/ChangeLog
    trunk/gcc/java/class.c

[Bug java/52730] Java front end emits assembly

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-29 21:03:07 UTC ---
Java now emits a constructor to a static variable with DECL_SECTION_NAME set to
the .jcr section name.