[Bug libgcj/55716] New: [4.8 Regression] gjavah crashes

[Bug libgcj/55716] New: [4.8 Regression] gjavah crashes

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

             Bug #: 55716
           Summary: [4.8 Regression] gjavah crashes
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcj
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jakub@gcc.gnu.org


For redhat/gcc-4_X-branch, I remove all gjavah --cni generated headers (and
*.class files and *.jar files except for libjava.jar testcase), then build with
--enable-java-maintainer-mode.
If I use gcc 4.7.2 gjavah for that (also on the trunk tree), everything works
fine, but with gcc 4.8.0 gjavah it fails.

$ gjavah --cni --all ../../../libjava/classpath/lib
--cmdfile=../../../libjava/headers.txt -d ../../../libjava --force
java.io.IOException: can't find class file
gnu/xml/stream/XMLParser$ContentModel.class in
java.net.URLClassLoader{urls=[file:/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/rt.jar],
parent=gnu.gcj.runtime.SystemClassLoader{urls=[file:./],
parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}}}
    at gnu.classpath.tools.javah.Main.getClass(libgcj-tools.so.14)
    at gnu.classpath.tools.javah.Main.parseClasses(libgcj-tools.so.14)
    at gnu.classpath.tools.javah.Main.parseClasses(libgcj-tools.so.14)
    at gnu.classpath.tools.javah.Main.run(libgcj-tools.so.14)
    at gnu.classpath.tools.javah.Main.main(libgcj-tools.so.14)

Usually I'm using hack like
# If we don't have gjavah in $PATH, try to build it with the old gij            
mkdir java_hacks                                                                
cd java_hacks                                                                   
cp -a ../../libjava/classpath/tools/external external                           
mkdir -p gnu/classpath/tools                                                    
cp -a ../../libjava/classpath/tools/gnu/classpath/tools/{common,javah,getopt}
gnu/classpath/tools/                                                 
cp -a
../../libjava/classpath/tools/resource/gnu/classpath/tools/common/messages.properties
gnu/classpath/tools/common                             
cp -a
../../libjava/classpath/tools/resource/gnu/classpath/tools/getopt/messages.properties
gnu/classpath/tools/getopt                             
cd external/asm; for i in `find . -name \*.java`; do gcj --encoding ISO-8859-1
-C $i -I.; done; cd ../..                                           
for i in `find gnu -name \*.java`; do gcj -C $i -I. -Iexternal/asm/; done       
gcj -findirect-dispatch -O2 -fmain=gnu.classpath.tools.javah.Main -I.
-Iexternal/asm/ `find . -name \*.class` -o gjavah.real                       
cat > gjavah <<EOF                                                              
#!/bin/sh                                                                       
export CLASSPATH=`pwd`${CLASSPATH:+:$CLASSPATH}                                 
exec `pwd`/gjavah.real "\$@"                                                    
EOF                                                                             
chmod +x `pwd`/gjavah                                                           

and prepend that java_hacks/ into $PATH for gcc bootstrap, that method fails
the exact same way.  Initially I thought there would be some issue with this
way
of creating gjavah, but when I've used system gjavah (removed this one),
bootstrapped/regtested it fine, then installed the new gcc + gcc-java/libgcj
etc.,
and using the new (4.8.0) system gjavah it failed the same way.

[Bug libgcj/55716] [4.8 Regression] gjavah crashes

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aph at gcc dot gnu.org
   Target Milestone|---                         |4.8.0

[Bug libgcj/55716] [4.8 Regression] gjavah crashes

[mark at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

Mark Wielaard <mark at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at gcc dot gnu.org

--- Comment #1 from Mark Wielaard <mark at gcc dot gnu.org> 2012-12-17 09:43:08 UTC ---
gnu/xml/stream/XMLParser$ContentModel.class should be in rt.jar.
I assume that it is in the old rt.jar, but isn't in the new version?

$ jar tf /usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/rt.jar | grep XMLParser

After rebuilding the .class files, are the XLMLParser inner classes in the
tree?

$ find libjava -name XMLParser*class

[Bug libgcj/55716] [4.8 Regression] gjavah crashes

[mark at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

--- Comment #2 from Mark Wielaard <mark at gcc dot gnu.org> 2012-12-17 10:16:20 UTC ---
Hmmm, it might be that it is picking up the wrong "bootclasspath" in this case.
By default it tries to use System.getProperty("sun.boot.class.path") which I
assume is set to file:/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/rt.jar in
this case.

Does it help to explicitly add it to the gjavah invocation like -bootclasspath
../../../libjava/classpath/lib ?

It is a little strange if this (or maybe just -classpath
../../../libjava/classpath/lib) would work. I assume the directory on which you
run --all is in the default classpath. And you seem to explicitly set the
CLASSPATH environment variable (maybe that doesn't include all dirs/classes?)

[Bug libgcj/55716] [4.8 Regression] gjavah throws an exception

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-17 10:23:35 UTC ---
Those changes are likely:
2011-09-09  Andrew John Hughes  <ahughes@redhat.com>

        PR classpath/45526: Produce header files for
        any inner classes found.
        * tools/gnu/classpath/tools/javah/Main.java:
        (parsed): Set of class names that have been parsed.
        (writeHeader(Map,Printer)): Take a general Map
        rather than a specific HashMap.
        (parseClasses(Iterator<Object>)): Factor out
        the parsing of class files into a separate
        method so it can be called recursively for
        inner classes.
        (getClass(String)): Remove redundant cast.

and indeed, I've seen the exception thrown mentioning different classes, but
always it had some class$something.class string in it.

[Bug libgcj/55716] [4.8 Regression] gjavah throws an exception

[aph at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

--- Comment #5 from Andrew Haley <aph at gcc dot gnu.org> 2012-12-18 10:00:29 UTC ---
Author: aph
Date: Tue Dec 18 10:00:18 2012
New Revision: 194574

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194574
Log:
PR gcc/55716  [4.8 Regression] gjavah throws an exception

Modified:
    trunk/libjava/classpath/ChangeLog

[Bug libgcj/55716] [4.8 Regression] gjavah throws an exception

[aph at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55716

Andrew Haley <aph at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Andrew Haley <aph at gcc dot gnu.org> 2012-12-18 10:01:39 UTC ---
A comment must go here, apparently.