public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug java/63355] New: libjava/classpath/native/jni/gstreamer-peer/gst_native_pipeline.c:180: possible typo ?
Date: Wed, 24 Sep 2014 07:05:00 -0000	[thread overview]
Message-ID: <bug-63355-8172@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63355

            Bug ID: 63355
           Summary: libjava/classpath/native/jni/gstreamer-peer/gst_native
                    _pipeline.c:180: possible typo ?
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com

[trunk/libjava/classpath/native/jni/gstreamer-peer/gst_native_pipeline.c:180]:
(style) Same expression on both sides of '||'.

Source code is

  if (localGstPipelineClass == NULL || localGstPipelineClass == NULL)

I suspect 

  if (localPointerClass == NULL || localGstPipelineClass == NULL)

might have been intended, although it's probably better code
to have the test of localPointerClass immediately after it
is written to, not a few lines later.


                 reply	other threads:[~2014-09-24  7:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63355-8172@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=java-prs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).