From: "Jan Beulich" <JBeulich@suse.com>
To: "Bryce McKinlay" <bmckinlay@gmail.com>
Cc: <java@gcc.gnu.org>
Subject: Re: libjava build failure with read-only source tree
Date: Thu, 29 Sep 2011 09:48:00 -0000 [thread overview]
Message-ID: <4E845AED020000780005870B@nat28.tlf.novell.com> (raw)
In-Reply-To: <CALUNu-rTAeDOy+v+FcTMgvzdCDGvhP3Wg2_vF6KA3cEYwYsVog@mail.gmail.com>
>>> On 29.09.11 at 11:31, Bryce McKinlay <bmckinlay@gmail.com> wrote:
> On Thu, Sep 29, 2011 at 9:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
>
>> --- a/libjava/classpath/tools/Makefile.am
>> +++ b/libjava/classpath/tools/Makefile.am
>> @@ -371,6 +371,7 @@ endif
>> ## BEGIN GCJ LOCAL
>> cp -pR $(srcdir)/asm .
>> cp -pR $(srcdir)/classes .
>> + find asm classes -type d -exec chmod u+w \{\} \;
>> if [ -d asm/.svn ]; then \
>> find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \
>> fi
>
> This patch looks fine to me, though I wonder if there is any good
> reason why "cp -p" was used in the first place?
Perhaps to retain the timestamps of the files without becoming too
system specific (i.e. dependent on cp's support of
--preserve=timestamps)?
> In any case, I'd say you can go ahead and check this in under the
> "obvious" rule.
Yeah, probably.
Thanks, Jan
prev parent reply other threads:[~2011-09-29 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 8:18 Jan Beulich
2011-09-29 8:40 ` Bryce McKinlay
2011-09-29 9:06 ` Jan Beulich
2011-09-29 9:32 ` Bryce McKinlay
2011-09-29 9:34 ` Andrew Haley
2011-09-29 9:48 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E845AED020000780005870B@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=bmckinlay@gmail.com \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).