From: Andrew Haley <aph@redhat.com>
To: java@gcc.gnu.org
Subject: Re: [patch] C6X unwinding/exception handling
Date: Mon, 17 Oct 2011 11:21:00 -0000 [thread overview]
Message-ID: <4E9C0FB5.1050409@redhat.com> (raw)
In-Reply-To: <4E9C0B03.7070002@ubuntu.com>
On 10/17/2011 12:01 PM, Matthias Klose wrote:
> On 10/10/2011 02:23 PM, Paul Brook wrote:
>>> Index: libjava/exception.cc
>>> ===================================================================
>>> --- libjava/exception.cc (revision 179739)
>>> +++ libjava/exception.cc (working copy)
>>> @@ -135,6 +135,7 @@
>>> {
>>> _Unwind_Ptr Start;
>>> _Unwind_Ptr LPStart;
>>> + _Unwind_Ptr ttype_base;
>>> const unsigned char *TType;
>>> const unsigned char *action_table;
>>> unsigned char ttype_encoding;
>>> @@ -184,7 +185,7 @@
>>> _Unwind_Ptr ptr;
>>>
>>> ptr = (_Unwind_Ptr) (info->TType - (i * 4));
>>> - ptr = _Unwind_decode_target2(ptr);
>>> + ptr = _Unwind_decode_typeinfo_ptr (info->ttype_base, (_Unwind_Word)
>>> ptr);
>>>
>>> return reinterpret_cast<void **>(ptr);
>>> }
>>> @@ -325,6 +326,7 @@
>>>
>>> // Parse the LSDA header.
>>> p = parse_lsda_header (context, language_specific_data, &info);
>>> + info.ttype_base = base_of_encoded_value (info.ttype_encoding, context);
>>> #ifdef HAVE_GETIPINFO
>>> ip = _Unwind_GetIPInfo (context, &ip_before_insn);
>>> #else
>>
>> No. The purpose of my patch was to remove the arm specific code.
>>
>> The only difference I can see in this bit of code is that libstdc++ uses
>> base_of_encoded_value/read_encoded_value_with_base whereas libjava uses
>> context/read_encoded_value.
>>
>> I expect you want something like the patch below (completely untested).
>
> I checked the attached patch, test results at
> http://gcc.gnu.org/ml/gcc-testresults/2011-10/msg01377.html
>
> which are the same as with my suggested patch.
>
> Ok for the trunk?
OK. One question: where is_GLIBCXX_OVERRIDE_TTYPE_ENCODING defined?
Andrew.
next prev parent reply other threads:[~2011-10-17 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201108041531.58790.paul@codesourcery.com>
[not found] ` <201109131348.13087.paul@codesourcery.com>
2011-10-09 11:10 ` Matthias Klose
2011-10-10 10:33 ` Andrew Haley
2011-10-10 11:27 ` Matthias Klose
2011-10-10 12:23 ` Paul Brook
2011-10-17 11:01 ` Matthias Klose
2011-10-17 11:21 ` Andrew Haley [this message]
2011-10-17 11:27 ` Matthias Klose
2011-10-17 13:49 ` Paul Brook
2011-10-17 14:11 ` Nicola Pero
2011-10-20 12:29 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9C0FB5.1050409@redhat.com \
--to=aph@redhat.com \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).