From: Bryce McKinlay <bmckinlay@gmail.com>
To: Jack Howarth <howarth@bromo.med.uc.edu>
Cc: java@gcc.gnu.org
Subject: Re: shouldfail'ing sourcelocation
Date: Sun, 20 Jan 2013 01:16:00 -0000 [thread overview]
Message-ID: <CALUNu-qKC=vvq3MGpj1qcnFg5Bi2kXgmsq3mnzSM4-DLYyFm-g@mail.gmail.com> (raw)
In-Reply-To: <20130119152716.GA4052@bromo.med.uc.edu>
On Sat, Jan 19, 2013 at 3:27 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> How exactly can we shouldfail the sourcelocation test on those
> platforms like darwin which don't support dwarf4...
This should be an 'xfail', not a 'shouldfail'.
Unfortunately I don't think we ever had a mechanism to do
platform-specific xfails in the libjava testsuite. You could certainly
add that, but maybe just making the line numbers work would be a more
productive use of time :)
Note you don't need dwarf4 to make sourcelocation work (comment in the
test case is a bit misleading). You just need some way to read the
source line number info, whatever format it is in.
next prev parent reply other threads:[~2013-01-20 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 15:27 Jack Howarth
2013-01-20 1:16 ` Bryce McKinlay [this message]
2013-02-02 12:57 Dominique Dhumieres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALUNu-qKC=vvq3MGpj1qcnFg5Bi2kXgmsq3mnzSM4-DLYyFm-g@mail.gmail.com' \
--to=bmckinlay@gmail.com \
--cc=howarth@bromo.med.uc.edu \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).