* code is not clean. libjava/interpret.cc:1480
@ 2011-01-16 10:20 majia gm
2011-01-17 9:58 ` Andrew Haley
2011-01-17 23:51 ` Ian Lance Taylor
0 siblings, 2 replies; 3+ messages in thread
From: majia gm @ 2011-01-16 10:20 UTC (permalink / raw)
To: gcc, Java List
libjava/interpret.cc:1480
gcc 4.4.0, 4.4.2 and 4.5.2 have the same problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: code is not clean. libjava/interpret.cc:1480
2011-01-16 10:20 code is not clean. libjava/interpret.cc:1480 majia gm
@ 2011-01-17 9:58 ` Andrew Haley
2011-01-17 23:51 ` Ian Lance Taylor
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Haley @ 2011-01-17 9:58 UTC (permalink / raw)
To: java
On 01/16/2011 10:20 AM, majia gm wrote:
> libjava/interpret.cc:1480
>
> gcc 4.4.0, 4.4.2 and 4.5.2 have the same problem.
So it is, thanks.
Line 1477 should be:
exc[i].handler_type.i)).clazz;
I guess this code has rotted. Perhaps the non-direct-threaded case
should be removed, and perhaps it should have been removed at the
time; I suppose #define'd-out code will always rot.
Andrew.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: code is not clean. libjava/interpret.cc:1480
2011-01-16 10:20 code is not clean. libjava/interpret.cc:1480 majia gm
2011-01-17 9:58 ` Andrew Haley
@ 2011-01-17 23:51 ` Ian Lance Taylor
1 sibling, 0 replies; 3+ messages in thread
From: Ian Lance Taylor @ 2011-01-17 23:51 UTC (permalink / raw)
To: majia gm; +Cc: gcc, Java List, kgallowa
majia gm <gmmajia@gmail.com> writes:
> libjava/interpret.cc:1480
>
> gcc 4.4.0, 4.4.2 and 4.5.2 have the same problem.
What precisely are you trying to say?
If you are trying to say that this code will not compile if
DIRECT_THREADED is not defined, then I agree. It appears to have been
broken by this patch, which is where the code was first introduced:
2007-02-15 Kyle Galloway <kgallowa@redhat.com>
* interpret.cc (_Jv_InterpMethod::check_handler): New method.
I've CC'ed Kyle Galloway.
I assume that in practice DIRECT_THREADED is always defined. Looking at
libjava/include/java-interp.h, that does indeed appear to be the case.
Ian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-17 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-16 10:20 code is not clean. libjava/interpret.cc:1480 majia gm
2011-01-17 9:58 ` Andrew Haley
2011-01-17 23:51 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).