public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
	"jit@gcc.gnu.org" <jit@gcc.gnu.org>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libgccjit: Add convert vector
Date: Wed, 24 Jan 2024 12:33:53 -0500	[thread overview]
Message-ID: <14705a2385028450967d25cb6387892d2946393e.camel@redhat.com> (raw)
In-Reply-To: <b963fdad41d8b038e9da2e85319427c9472cff57.camel@zoho.com>

On Thu, 2023-12-21 at 16:01 -0500, Antoni Boucher wrote:
> Hi.
> This patch adds the support for the convert vector internal function.

Thanks for the patch.

> I'll need to double-check that making the decl a register is
> necessary.

I confess I don't know anything about this aspect of the patch, but
presumably you have this working within the rustc backend as well as in
the testcase.

Am I right in thinking that this is an elementwise conversion?  Might
be good to specify this in the docs and header file.

Otherwise looks good to me (with usual comment about updating the ABI
numbering as necessary)

Thanks
Dave


      parent reply	other threads:[~2024-01-24 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 21:01 Antoni Boucher
2024-01-19 21:00 ` Antoni Boucher
2024-01-24 17:33 ` David Malcolm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14705a2385028450967d25cb6387892d2946393e.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=bouanto@zoho.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).