public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: "정인배(Inbae Jeong)" <kukyakya@gmail.com>, jit@gcc.gnu.org
Subject: Re: Alignment not supported?
Date: Sun, 01 Jan 2017 00:00:00 -0000	[thread overview]
Message-ID: <1490641205.11099.67.camel@redhat.com> (raw)
In-Reply-To: <87vaqumy7f.fsf@mid.deneb.enyo.de>

On Mon, 2017-03-27 at 19:22 +0200, Florian Weimer wrote:
> * David Malcolm:
> 
> > Hence all of this pre-existing logic for setting the alignment of a
> > type is implemented with the c-family front-end code, which isn't
> > available from libgccjit.
> 
> Ah, I assumed it was a c-family target.
> 
> > Alternatively, it might make more sense to go with this earlier API
> > idea:
> > 
> > extern gcc_jit_type *
> > gcc_jit_type_set_alignment (gcc_jit_type *type,
> >                             int alignment);
> > 
> > or similar ("make_aligned" ?  "add_alignment" ?)
> > 
> > I think I prefer the latter approach, as it makes it explicit in
> > client
> > code linkage metadata what functionality it's using,
> 
> It's also more type-safe and self-documenting.  Although “int”
> probably isn't exactly the right type here.

"unsigned int" ?


  reply	other threads:[~2017-03-27 19:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-01  0:00 정인배(Inbae Jeong)
2017-01-01  0:00 ` Florian Weimer
2017-01-01  0:00   ` 정인배(Inbae Jeong)
2017-01-01  0:00     ` [PATCH] Work-in-progress: gcc_jit_type_get_aligned David Malcolm
2017-01-01  0:00       ` Florian Weimer
2017-01-01  0:00         ` [PATCH] Add gcc_jit_type_get_aligned David Malcolm
2017-01-01  0:00           ` David Malcolm
2017-01-01  0:00     ` Alignment not supported? David Malcolm
2017-01-01  0:00       ` Florian Weimer
2017-01-01  0:00         ` David Malcolm
2017-01-01  0:00           ` David Malcolm
2017-01-01  0:00             ` Florian Weimer
2017-01-01  0:00               ` David Malcolm [this message]
2017-01-01  0:00                 ` Florian Weimer
2017-01-01  0:00           ` Florian Weimer
2017-01-01  0:00     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490641205.11099.67.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=fw@deneb.enyo.de \
    --cc=jit@gcc.gnu.org \
    --cc=kukyakya@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).