From: David Malcolm <dmalcolm@redhat.com>
To: Andrea Corallo <Andrea.Corallo@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <1560897082.3885.10.camel@redhat.com> (raw)
In-Reply-To: <gkra7epx0lv.fsf@arm.com>
On Mon, 2019-06-10 at 09:15 +0000, Andrea Corallo wrote:
> Hi all,
> I would like to propose this patch to check for the return type of
> binary operators to be a numeric type.
> Not doing so can lead the compiler into funny crashes.
>
> Does not introduce regressions running make check-jit.
>
> OK for trunk?
>
> Bests
> Andrea
>
> 2019-06-09 Andrea Corallo andrea.corallo@arm.com
>
> * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to
> be a
> numeric type.
Thanks for this patch. Please can you add a test case that triggers
the error-handling case? (I'm trying to imagine a situation where this
could have happened).
See gcc/testsuite/jit.dg/test-error-new-binary-op-bad-op.c or similar.
Dave
next prev parent reply other threads:[~2019-06-18 22:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Andrea Corallo
2019-01-01 0:00 ` David Malcolm [this message]
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560897082.3885.10.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=Andrea.Corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).