From: David Malcolm <dmalcolm@redhat.com>
To: Andrea Corallo <Andrea.Corallo@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <1562078770.2530.36.camel@redhat.com> (raw)
In-Reply-To: <gkrblyk9ylp.fsf@arm.com>
On Wed, 2019-06-26 at 15:05 +0000, Andrea Corallo wrote:
> David Malcolm writes:
>
> > On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote:
> > > Hi,
> > > third version for this patch with the simplified test.
> > >
> > > make check-jit pass clean
> > >
> > > Bests
> > > Andrea
> > >
> > > 2019-06-09 Andrea Corallo andrea.corallo@arm.com
> > >
> > > * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type
> > > to
> > > be a
> > > numeric type.
> > >
> > >
> > > 2019-06-20 Andrea Corallo andrea.corallo@arm.com
> > >
> > > * jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c:
> > > New testcase.
> >
> > Thanks for the updated patch.
> >
> > This is good for trunk.
> >
> > (Copying and pasting from my other review): are you working on
> > getting
> > SVN commit access, or do you want me to commit your two patches on
> > your
> > behalf?
> >
> > Thanks
> > Dave
>
> Hi David,
> I can work on to get the SVN commit access.
> As a maintainer has to sponsor it would you mind being the one?
https://www.gnu.org/software/gcc/svnwrite.html says:
"a well-established GCC maintainer (including reviewers) can approve
for write access any person with GNU copyright assignment papers in
place and known to submit good patches."
Thanks for your patches so far.
I approve of you getting "Write after approval" access to GCC svn,
provided the copyright assignment paperwork is in place (which I'm
assuming is, based on your @arm.com email address).
I'm not quite sure what the next steps are.
Dave
next prev parent reply other threads:[~2019-07-02 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` David Malcolm [this message]
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562078770.2530.36.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=Andrea.Corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).