Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

[Antoni Boucher <bouanto@zoho.com>]

I believe you forgot to regenerate the ChangeLog.

Le 2024-04-22 à 09 h 16, Guillaume Gomez a écrit :
> Good point!
> 
> New patch attached.
> 
> Le lun. 22 avr. 2024 à 15:13, Antoni Boucher <bouanto@zoho.com> a écrit :
>>
>> Please move the function to be on lvalue since there are no rvalue types
>> that are not lvalues that have a name.
>>
>> Le 2024-04-22 à 09 h 04, Guillaume Gomez a écrit :
>>> Hey Arthur :)
>>>
>>>> Is there any reason for that getter to return a mutable pointer to the
>>>> name? Would something like this work instead if you're just looking at
>>>> getting the name?
>>>>
>>>> +  virtual string * get_name () const { return NULL; }
>>>>
>>>> With of course adequate modifications to the inheriting classes.
>>>
>>> Good catch, thanks!
>>>
>>> Updated the patch and attached the new version to this email.
>>>
>>> Cordially.
>>>
>>> Le lun. 22 avr. 2024 à 11:51, Arthur Cohen <arthur.cohen@embecosm.com> a écrit :
>>>>
>>>> Hey Guillaume :)
>>>>
>>>> On 4/20/24 01:05, Guillaume Gomez wrote:
>>>>> Hi,
>>>>>
>>>>> I just encountered the need to retrieve the name of an `rvalue` (if
>>>>> there is one) while working on the Rust GCC backend.
>>>>>
>>>>> This patch adds a getter to retrieve the information.
>>>>>
>>>>> Cordially.
>>>>
>>>>>      virtual bool get_wide_int (wide_int *) const { return false; }
>>>>>
>>>>> +  virtual string * get_name () { return NULL; }
>>>>> +
>>>>>    private:
>>>>>      virtual enum precedence get_precedence () const = 0;
>>>>
>>>> Is there any reason for that getter to return a mutable pointer to the
>>>> name? Would something like this work instead if you're just looking at
>>>> getting the name?
>>>>
>>>> +  virtual string * get_name () const { return NULL; }
>>>>
>>>> With of course adequate modifications to the inheriting classes.
>>>>
>>>> Best,
>>>>
>>>> Arthur