Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

[Arthur Cohen <arthur.cohen@embecosm.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 796 bytes --]

Hey Guillaume :)

On 4/20/24 01:05, Guillaume Gomez wrote:
> Hi,
> 
> I just encountered the need to retrieve the name of an `rvalue` (if
> there is one) while working on the Rust GCC backend.
> 
> This patch adds a getter to retrieve the information.
> 
> Cordially.

>    virtual bool get_wide_int (wide_int *) const { return false; }
>  
> +  virtual string * get_name () { return NULL; }
> +
>  private:
>    virtual enum precedence get_precedence () const = 0;

Is there any reason for that getter to return a mutable pointer to the 
name? Would something like this work instead if you're just looking at 
getting the name?

+  virtual string * get_name () const { return NULL; }

With of course adequate modifications to the inheriting classes.

Best,

Arthur

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3195 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]