Re: [PATCH] libgccjit: Allow comparing vector types

[David Malcolm <dmalcolm@redhat.com>]

On Tue, 2022-12-13 at 16:27 -0500, Antoni Boucher wrote:
> Thanks!
> 
> David: you mentioned gcc 10. For now, I only intend to make changes
> to
> the next release (13). Is this OK or should I backport all my fixes
> to
> all active releases? (I'm not sure what are GCC policies here.)

I think it varies by subproject within GCC.

Given that this could arguably be an RFE rather than a bugfix, and that
rustc_codegen_gcc is likely the primary user of this stuff, I leave the
decision of which branches to you.  If you only want it in trunk for
gcc 13 onwards, then that's fine by me.

Thanks again for the patch
Dave 

> 
> On Tue, 2022-12-13 at 16:24 -0500, David Malcolm wrote:
> > On Mon, 2022-12-12 at 21:31 -0500, Antoni Boucher via Jit wrote:
> > > Hi.
> > > This fixes bug 108078.
> > > Thanks for the review.
> > 
> > [...snip...]
> > 
> > > diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h
> > > index 5d7c7177cc3..4ec0fff4843 100644
> > > --- a/gcc/jit/jit-recording.h
> > > +++ b/gcc/jit/jit-recording.h
> > > @@ -806,6 +806,15 @@ public:
> > >  
> > >    void replay_into (replayer *) final override;
> > >  
> > > +  virtual bool is_same_type_as (type *other)
> > 
> > This would be better with a "final override" (and without the
> > "virtual").
> > 
> > > +  {
> > > +    vector_type *other_vec_type = other->dyn_cast_vector_type
> > > ();
> > > +    if (other_vec_type == NULL)
> > > +      return false;
> > > +    return get_num_units () == other_vec_type->get_num_units ()
> > > +      && get_element_type () == other_vec_type->get_element_type
> > > ();
> > > +  }
> > > +
> > 
> > OK for active branches with that nit fixed (though for gcc 10 you'd
> > have to spell final and override as "FINAL" and "OVERRIDE" due to
> > needing to be buildable with a C++98 compiler; not sure if gcc 10's
> > libgccjit even has vector types though).
> > 
> > [...snip...]
> > 
> > Thanks for the patch
> > 
> > Dave
> > 
>