From: David Malcolm <dmalcolm@redhat.com>
To: Petter Tomner <tomner@kth.se>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>
Subject: Re: Sv: [PATCH 1/2 v2] jit : Generate debug info for variables
Date: Wed, 08 Sep 2021 08:48:39 -0400 [thread overview]
Message-ID: <4752e7eeda98e1b15e2adf0abdfc04313663ca32.camel@redhat.com> (raw)
In-Reply-To: <75de9fbd1bcf460a8aeb48fde2072d96@kth.se>
On Tue, 2021-09-07 at 16:18 +0000, Petter Tomner via Gcc-patches wrote:
> I realized I still managed to mess up some WS. I have attached a
> patch that is the same, except fixes the WS issue
> underneath.
>
> Regards, Petter
>
> + FOR_EACH_VEC_ELT (m_globals, i, global)
> + rest_of_decl_compilation (global, true, true);
Thanks for the updated patch.
Looks good to me, assuming it's been tested successfully. It should be
combined with the testcase into a single commit when pushed.
Do you have push rights to the GCC git repo?
Dave
next prev parent reply other threads:[~2021-09-08 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 23:48 Petter Tomner
2021-09-07 16:18 ` Sv: " Petter Tomner
2021-09-08 12:48 ` David Malcolm [this message]
2021-09-09 7:45 ` Sv: " Petter Tomner
2021-09-09 12:41 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4752e7eeda98e1b15e2adf0abdfc04313663ca32.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=tomner@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).