From: Antoni Boucher <bouanto@zoho.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Add function to set the initial value of a global variable [PR96089]
Date: Fri, 11 Jun 2021 16:44:38 -0400 [thread overview]
Message-ID: <62c178b5bb0ab004def3c7869da2b03846e5134c.camel@zoho.com> (raw)
In-Reply-To: <7d6762623f658712a4b802cc3d6524c106affa2b.camel@zoho.com>
David: this one wasn't reviewed yet by you, so you can review it.
Le jeudi 20 mai 2021 à 21:27 -0400, Antoni Boucher a écrit :
> Hi.
>
> I made this patch to set an arbitrary value to a global variable.
>
> This patch suffers from the same issue as inline assembly
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100380), i.e. it
> segfaults if the `rvalue` is created after the global variable.
> It seems to be a design issue so I'm not sure what would be the fix
> for
> it and having it fixed would allow me to test this new function much
> more and see if things are missing (i.e. it might require a way to
> create a constant struct).
> See the link above for an explanation of this issue.
>
> Thanks for the review.
next prev parent reply other threads:[~2021-06-11 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 1:27 Antoni Boucher
2021-06-11 20:44 ` Antoni Boucher [this message]
2021-11-23 2:01 ` Antoni Boucher
2021-11-23 10:51 ` SV: " Petter Tomner
2021-11-23 14:10 ` Antoni Boucher
2021-11-24 13:38 ` SV: " Petter Tomner
2021-11-30 1:34 ` David Malcolm
2021-11-30 14:37 ` SV: " Petter Tomner
2021-12-02 0:07 ` David Malcolm
2021-12-02 22:58 ` Antoni Boucher
2021-12-06 10:56 ` SV: " Petter Tomner
2021-12-06 10:51 ` Petter Tomner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c178b5bb0ab004def3c7869da2b03846e5134c.camel@zoho.com \
--to=bouanto@zoho.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).