Re: [PATCH] libgccjit: Implement sizeof operator

[David Malcolm <dmalcolm@redhat.com>]

On Wed, 2024-01-10 at 17:38 -0500, Antoni Boucher wrote:
> On Tue, 2024-01-09 at 11:33 -0500, David Malcolm wrote:
> > On Fri, 2023-12-22 at 10:25 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch adds the support of the sizeof operator.
> > > I was wondering if this new API entrypoint should take a location
> > > as
> > > a
> > > parameter. What do you think?
> > 
> > I'd prefer it if it did (even if it's currently ignored
> > internally),
> > but it's not a big deal.
> 
> The reason it doesn't have a location is because it directly produces
> a
> constant, rather like gcc_jit_context_new_rvalue_from_int, which
> doesn't have a location either.
> So, I wanted to confirm that you think it's needed to have a
> location.

Fair enough; it's not needed.

> 
> Also, I realized I misnamed memento_of_new_sizeof and will rename it
> to
> memento_of_sizeof.

Ah, ok.  Fixing that is preapproved, though make sure it still builds
and test it a little before pushing!

Please also doublecheck the ABI version numbers, since they inevitably
tend to get out of sync on branches.

Dave

> 
> > 
> > > Thanks for the review.
> > 
> > The patch is OK as-is.
> > 
> > Thanks
> > Dave
> > 
>