From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Cc: Guillaume Gomez <guillaume1.gomez@gmail.com>
Subject: Re: [PATCH] libgccjit: Fix float vector comparison
Date: Thu, 01 Dec 2022 10:25:11 -0500 [thread overview]
Message-ID: <74150b934836583a532d310c68d29384daf2fbd0.camel@redhat.com> (raw)
In-Reply-To: <15fbee19972751bfa05c24ec95bc441c621c98ad.camel@zoho.com>
On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote:
> Thanks, David.
> Since we're not in phase 1 anymore, do we need an approval before I
> merge like last year or can I merge immediately?
I think it counts as a bug fix and thus you can go ahead and merge
(assuming you've done the usual testing).
> I also have many other patches (all in jit) that I need to prepare
> and
> post to this mailing list.
> What do you think?
Given that you're one of the main users of libgccjit I think there's a
case for stretching the deadlines a bit here.
Do you have a repo I can look at?
Dave
>
> On Thu, 2022-12-01 at 09:28 -0500, David Malcolm wrote:
> > On Sun, 2022-11-20 at 14:03 -0500, Antoni Boucher via Jit wrote:
> > > Hi.
> > > This fixes bug 107770.
> > > Thanks for the review.
> >
> > Thanks, the patch looks good to me.
> >
> > Dave
> >
>
next prev parent reply other threads:[~2022-12-01 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 19:03 Antoni Boucher
2022-11-30 19:58 ` Antoni Boucher
2022-12-01 14:28 ` David Malcolm
2022-12-01 15:01 ` Antoni Boucher
2022-12-01 15:25 ` David Malcolm [this message]
2022-12-01 15:33 ` Antoni Boucher
2022-12-01 16:57 ` David Malcolm
2022-12-02 14:29 ` Antoni Boucher
2023-01-12 16:29 ` Antoni Boucher
2022-12-03 3:10 ` Antoni Boucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74150b934836583a532d310c68d29384daf2fbd0.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bouanto@zoho.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guillaume1.gomez@gmail.com \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).