From: Xi Ruoyao <xry111@xry111.site>
To: Icenowy Zheng <uwu@icenowy.me>, gcc-patches@gcc.gnu.org
Cc: jit@gcc.gnu.org, Lulu Cheng <chenglulu@loongson.cn>
Subject: Re: [PATCH 0/2] LoongArch: respect --with-* and drop loongarch-driver
Date: Fri, 09 Dec 2022 15:51:26 +0800 [thread overview]
Message-ID: <86d0c6e7fd272f598ee7a3c0f1aae7cae66ecd9c.camel@xry111.site> (raw)
In-Reply-To: <20221209024349.845948-1-uwu@icenowy.me>
On Fri, 2022-12-09 at 10:43 +0800, Icenowy Zheng wrote:
> This patchset tries to fix the object duplication between the driver and
> the real compiler, which makes libgccjit building fail because of
> linking this two parts together.
Hmm, I think the issue is already fixed by https://gcc.gnu.org/r13-1010
but maybe I'm wrong here...
This looks like a good code clean-up anyway. But if libgccjit builds
fine with GCC trunk I'd postpone the clean-up to GCC 14 stage 1.
> First, the build-time --with-* values are now respected by being the
> default -m* values in the driver, and then loongarch-driver, which is
> mostly doing no-op now, is dropped.
>
> This patchset is bootstrapped on a native LoongArch device (without
> any
> --with-* flags). In addition, on a x86 device, cross compilers are
> built
> with --with-{arch,abi} and without any --with-* flags; all these
> configurations can correctly build all supported shipped libraries
> with
> GCC.
>
> Icenowy Zheng (2):
> LoongArch: respect the with values in config.gcc
> LoongArch: drop loongarch-driver
>
> gcc/config.gcc | 1 -
> gcc/config/loongarch/loongarch-driver.cc | 187 ----------------------
> -
> gcc/config/loongarch/loongarch-driver.h | 68 ---------
> gcc/config/loongarch/loongarch.h | 21 ++-
> 4 files changed, 19 insertions(+), 258 deletions(-)
> delete mode 100644 gcc/config/loongarch/loongarch-driver.cc
> delete mode 100644 gcc/config/loongarch/loongarch-driver.h
>
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
prev parent reply other threads:[~2022-12-09 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221209024349.845948-1-uwu@icenowy.me>
2022-12-09 2:43 ` [PATCH 1/2] LoongArch: respect the with values in config.gcc Icenowy Zheng
2022-12-09 2:43 ` [PATCH 2/2] LoongArch: drop loongarch-driver Icenowy Zheng
2022-12-09 7:51 ` Xi Ruoyao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d0c6e7fd272f598ee7a3c0f1aae7cae66ecd9c.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).