From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: jit@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Handle truncation and extension for casts [PR 95498]
Date: Thu, 08 Jul 2021 17:34:42 -0400 [thread overview]
Message-ID: <a1517bb608d804120be5879a23b1f521d49b0e0b.camel@redhat.com> (raw)
In-Reply-To: <dc15cde5f7f16ac1297b4f8d25d1bffe7f5c3417.camel@zoho.com>
On Thu, 2021-07-08 at 17:28 -0400, Antoni Boucher wrote:
> Is this the approval for write or are we not there yet?
Assuming it passes the regression tests, yes - approved for trunk.
Dave
>
> Le jeudi 08 juillet 2021 à 16:44 -0400, David Malcolm a écrit :
> > On Tue, 2021-07-06 at 09:00 -0400, Antoni Boucher wrote:
> > > I updated the patch to fix this.
> > > I'm sending the patch once again for review.
> > > Thanks.
> >
> > Looks good to me.
> >
> > Dave
> >
> > >
> > > Le samedi 19 juin 2021 à 11:08 +0200, Bernhard Reutner-Fischer a
> > > écrit :
> > > > On 18 June 2021 23:11:58 CEST, Antoni Boucher via Gcc-patches
> > > > <gcc-patches@gcc.gnu.org> wrote:
> > > > > Ok.
> > > > > Here's the patch with the updated subject and with format
> > > > > fixed.
> > > >
> > > > + if (t_ret)
> > > > + return t_ret;
> > > > + enum tree_code dst_code = TREE_CODE (dst_type);
> > > > + switch (dst_code)
> > > > + {
> > > >
> > > > The enum is redundant.
> > > > /enum tree_code/s/enum //
> > > > thanks,
> > >
> >
> >
>
>
prev parent reply other threads:[~2021-07-08 21:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 0:30 Antoni Boucher
2020-07-14 21:15 ` David Malcolm
2020-07-21 21:29 ` Andrea Corallo
2020-10-15 19:00 ` Antoni Boucher
2021-02-13 1:35 ` Antoni Boucher
2021-02-20 18:20 ` Tom Tromey
2021-02-20 22:17 ` Antoni Boucher
2021-05-13 8:34 ` Martin Liška
2021-05-13 22:13 ` David Malcolm
2021-05-13 23:31 ` Antoni Boucher
2021-05-13 23:58 ` David Malcolm
2021-05-26 0:16 ` Antoni Boucher
2021-05-27 22:21 ` David Malcolm
2021-05-28 1:22 ` Antoni Boucher
2021-06-11 17:49 ` David Malcolm
2021-06-18 20:42 ` Antoni Boucher
2021-06-18 20:54 ` David Malcolm
2021-06-18 21:11 ` Antoni Boucher
2021-06-19 9:08 ` Bernhard Reutner-Fischer
2021-07-06 13:00 ` Antoni Boucher
2021-07-08 20:44 ` David Malcolm
2021-07-08 21:28 ` Antoni Boucher
2021-07-08 21:34 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1517bb608d804120be5879a23b1f521d49b0e0b.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bouanto@zoho.com \
--cc=jit@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).