From: Petter Tomner <tomner@kth.se>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>
Subject: [PATCH 0/2 v2] jit : Generate debug info for variables
Date: Sat, 4 Sep 2021 23:40:01 +0000 [thread overview]
Message-ID: <bc3b319b95a0468986dc8e4eaff854c9@kth.se> (raw)
Hi,
This is a revision of my patch for debug info.
The patches are posted as mails to this thread. Make check-jit runs fine on Debian x64.
Below is the original mail and under it a rehash of the review comments.
Regards, Petter
---------------------------------------------------------------------------------------------------------
Hi,
This is a patch to generate debug info for local variables as well as globals.
With this, "ptype foo", "info variables", "info locals" etc works when debugging in GDB.
Finalizing of global variable declares are moved to after locations are handled and done
as Fortran, C, Go etc do it. Also, primitive types have their TYPE_NAME set for debug info
on types to work.
Below are the patch, and I attached a testcase. Since it requires GDB to run it might
not be suitable? Make check-jit runs fine on Debian x64.
Regards,
---------------------------------------------------------------------------------------------------------
> Can you write non-empty ChangeLog entries please.
Done. I think the python script chokes on asd/qwe/jit.db/ (the dot) though.
> @@ -2984,15 +2975,22 @@ replay ()
> Looks like some whitespace churn above
Fixed.
> I don't see "Signed-off-by" tags in the patches.
Added.
> I think this should be "unsupported" rather than "xfail".
Changed.
> This is OK, but maybe using gcc_jit_context_dump_to_file with
update_locations == 1 might be more sustainable in the long run?
Ye I didn't remember that flag. Entering loc manually aint no fun.
reply other threads:[~2021-09-04 23:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc3b319b95a0468986dc8e4eaff854c9@kth.se \
--to=tomner@kth.se \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).