From: David Malcolm <dmalcolm@redhat.com>
To: Andrea Corallo <andrea.corallo@arm.com>
Cc: "jit@gcc.gnu.org" <jit@gcc.gnu.org>, nd <nd@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2][gcc] libgccjit: handle long literals in playback::context::new_string_literal
Date: Fri, 20 Mar 2020 21:41:05 -0400 [thread overview]
Message-ID: <f0f9c19f0d1db0523f7c28904e69bb8c81deb5e4.camel@redhat.com> (raw)
In-Reply-To: <87tv2x9nmi.fsf_-_@arm.com>
On Mon, 2020-03-09 at 22:20 +0000, Andrea Corallo wrote:
> Hi all,
>
> second version of the patch for the 200 characters limit for literal
> strings addressing comments.
>
> make check-jit is passing clean.
>
> Best Regards
> Andrea
>
> gcc/jit/ChangeLog
> 2020-??-?? Andrea Corallo <andrea.corallo@arm.com>
>
> * jit-playback.h
> (gcc::jit::playback::context m_recording_ctxt): Remove
> m_char_array_type_node field.
> * jit-playback.c
> (playback::context::context) Remove m_char_array_type_node from
> member
> initializer list.
> (playback::context::new_string_literal) Fix logic to handle
> string
> length > 200.
>
> gcc/testsuite/ChangeLog
> 2020-??-?? Andrea Corallo <andrea.corallo@arm.com>
>
> * jit.dg/all-non-failing-tests.h: Add test-long-string-
> literal.c.
> * jit.dg/test-long-string-literal.c: New testcase.
>
diff --git a/gcc/testsuite/jit.dg/all-non-failing-tests.h b/gcc/testsuite/jit.dg/all-non-failing-tests.h
index 0272e6f846f..1b3d5618779 100644
--- a/gcc/testsuite/jit.dg/all-non-failing-tests.h
+++ b/gcc/testsuite/jit.dg/all-non-failing-tests.h
@@ -220,6 +220,13 @@
#undef create_code
#undef verify_code
+/* test-long-string-literal.c */
+#define create_code create_code_long_string_literal
+#define verify_code verify_code_long_string_literal
+#include "test-long-string-literal.c"
+#undef create_code
+#undef verify_code
+
Please adjust where you add this so that these things are in
alphabetical order.
An entry also needs to be added to the "testcases" array at the end of
the header for this to do anything.
OK with that change.
David
next prev parent reply other threads:[~2020-03-21 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [PATCH][gcc] " Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Andrea Corallo
2020-01-01 0:00 ` David Malcolm
2020-03-07 21:43 ` Andrea Corallo
2020-03-09 22:20 ` [PATCH v2][gcc] " Andrea Corallo
2020-03-18 22:52 ` Andrea Corallo
2020-03-21 1:41 ` David Malcolm [this message]
2020-03-23 18:04 ` [committed][gcc] " Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f9c19f0d1db0523f7c28904e69bb8c81deb5e4.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=andrea.corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).