From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libgccjit: Add missing builtins needed by optimizations
Date: Wed, 10 Jan 2024 18:31:33 -0500 [thread overview]
Message-ID: <f24d508dad8bd0b3735b08173a6077f260b1d122.camel@redhat.com> (raw)
In-Reply-To: <73a2fc40fa7db02da413580f2c0a7fda23c6b817.camel@zoho.com>
On Wed, 2024-01-10 at 17:02 -0500, Antoni Boucher wrote:
> Just to make sure since we are in stage 4.
Are we? I haven't seen an announcement, and it looked from
https://gcc.gnu.org/pipermail/gcc/2024-January/243117.html
that we might be pushing back the date for it.
> Does that mean I can merge it?
This one is very low risk, so please go ahead and merge it.
>
> In general, how would I know if it's OK to merge?
> If the patch is in the state Accepted on patchwork, does that mean
> it's
> always OK to merge no matter the stage we're in?
AIUI, the status in patchwork is purely to help keep track of patch
reviews; whether or not a patch is suitable to push at a given time is
probably on a case-by-case basis (the key question being "how likely is
merging the patch going to cause problems")
Dave
>
> On Tue, 2024-01-09 at 11:35 -0500, David Malcolm wrote:
> > On Fri, 2023-12-22 at 09:39 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch adds missing builtins needed by optimizations.
> > > Thanks for the review.
> >
> > The patch looks good to me.
> >
> > Thanks!
> > Dave
> >
>
prev parent reply other threads:[~2024-01-10 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 14:39 Antoni Boucher
2024-01-09 16:35 ` David Malcolm
2024-01-10 22:02 ` Antoni Boucher
2024-01-10 23:31 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f24d508dad8bd0b3735b08173a6077f260b1d122.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bouanto@zoho.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).