From: akrl <akrl@sdf.org>
To: David Malcolm <dmalcolm@redhat.com>
Cc: marc@nieper-wisskirchen.de, basile@starynkevitch.net, jit@gcc.gnu.org
Subject: Re: about header file parsing
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <xjfftu0rz2s.fsf@sdf.org> (raw)
In-Reply-To: <1547148632.7788.167.camel@redhat.com> (message from David Malcolm on Thu, 10 Jan 2019 14:30:32 -0500)
David Malcolm <dmalcolm@redhat.com> writes:
> On Thu, 2019-01-10 at 19:06 +0000, akrl wrote:
>
> [...]
>
>> Hi,
>> today I've wrote a patch that adds GCC_JIT_STR_NEEDED_LIBRARIES to
>> gcc_jit_str_option.
>> This was to specify a space separated list of the libraries to link
>> against.
>> I was going to submit the patch for review but this solution seams to
>> be
>> more general.
>
> FWIW, although it sounds like it's no longer relevant here, I prefer to
> avoid extending the
> enum gcc_jit_str_option
> and
> enum gcc_jit_int_option
> enumerations, in favor of adding new API entrypoints, for the ABI-
> detection reason given here:
> https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#options
>
> i.e. "Adding entrypoints for each new option means that client code
> that use the new options can be identified directly from binary
> metadata, which would not be possible if we instead extended the
> various enum gcc_jit_*_option."
Okay then lets go for gcc_jit_context_add_driver_option then.
>
>> If we agree on an interface I propose my self to do the patch in
>> order
>> to have the occasion to setup the whole process.
>>
>> Bests
>>
>> Andrea
>
> It's great to have new contributors to the project.
>
> Andrea: FWIW, the FSF requires some legal paperwork before I can accept
> non-trivial patches; see:
> https://gcc.gnu.org/contribute.html#legal
> If you're hoping to send non-trivial patches, it might be an idea to
> look into that (unless you already have the FSF paperwork in place?)
Yes thanks I'm aware of the process. I'm sorting that out together with
my employer these days.
Bests!
Andrea
--
akrl@sdf.org
next prev parent reply other threads:[~2019-01-10 21:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 akrl
2019-01-01 0:00 ` Basile Starynkevitch
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` akrl [this message]
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Basile Starynkevitch
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` Basile Starynkevitch
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` Basile Starynkevitch
2019-01-01 0:00 ` akrl
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
2019-01-01 0:00 ` David Malcolm
[not found] <df8944b7-1fbe-b56f-cc48-ab926d0cb5ad@starynkevitch.net>
2019-01-01 0:00 ` Basile Starynkevitch
2019-01-01 0:00 ` Marc Nieper-Wißkirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfftu0rz2s.fsf@sdf.org \
--to=akrl@sdf.org \
--cc=basile@starynkevitch.net \
--cc=dmalcolm@redhat.com \
--cc=jit@gcc.gnu.org \
--cc=marc@nieper-wisskirchen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).